Security hardening: CSRF, rate limiting, session/password policy, audit log
Fixes critical pre-existing issues found during review: bulk_action.php had no auth check at all (unauthenticated download/delete of any qrcode) and built a table name from unwhitelisted user input (SQL injection); the QR generator classes wrote files from unvalidated filename/format, allowing path traversal and arbitrary file writes. Also pins chillerlan/php-qrcode to 5.0.5 since master now requires PHP 8.4, breaking the PHP 8.3 build. - CSRF tokens on all POST forms and the bulk_action.php JSON endpoint - Login rate limiting (5 attempts / 15 min) via new login_attempts table - Hardened sessions: httponly/samesite cookies, 30 min idle timeout, session regeneration on login - Forced password change for the default superadmin/superadmin account - Server-side validation in Users/DynamicQrcode/Qrcode classes - Audit log table for auth, user, and qrcode actions - Checked-in db schema (db/init.sql, migrations/) instead of relying on an opaque prebuilt db image - Production docker-compose with Nginx + php-fpm instead of the PHP dev server
This commit is contained in:
+14
-4
@@ -1,10 +1,20 @@
|
||||
<?php
|
||||
require_once './config/config.php';
|
||||
session_start();
|
||||
require_once 'includes/bootstrap.php';
|
||||
|
||||
if (!empty($_SESSION['user_logged_in'])) {
|
||||
audit_log('logout');
|
||||
}
|
||||
|
||||
$_SESSION = [];
|
||||
|
||||
if (ini_get('session.use_cookies')) {
|
||||
$params = session_get_cookie_params();
|
||||
setcookie(session_name(), '', time() - 42000, $params['path'], $params['domain'], $params['secure'], $params['httponly']);
|
||||
}
|
||||
|
||||
session_destroy();
|
||||
|
||||
|
||||
if(isset($_COOKIE['series_id']) && isset($_COOKIE['remember_token'])){
|
||||
if (isset($_COOKIE['series_id']) && isset($_COOKIE['remember_token'])) {
|
||||
clearAuthCookie();
|
||||
}
|
||||
header('Location:index.php');
|
||||
|
||||
Reference in New Issue
Block a user