M2: full backup runs (database, config, data) with occ and cron

BackupService starts a run per location (database dump in one transaction, then config + data directory as a resumable file run), stores the state in ngb_runs after every step, locks a run while a step executes and records the snapshot. Previews, logs, updater backups and per-user cache/uploads are excluded (TreeWalker now supports patterns). BackupJob (every 5 min) starts the daily schedule and steps running runs with a short budget under web cron and a long one under system cron. occ: backup:run, backup:status, backup:list. Tested on NC34/PostgreSQL: first run 128 files / 1 GiB in 64 s (443 MiB uploaded to S3), unchanged second run 2 s / 0 bytes; a background run to SFTP completed through cron.php.
2026-10-02 00:53:50 +02:00
parent 9cefea019d
commit 2ab4b2e7d5
12 changed files with 693 additions and 15 deletions
@@ -0,0 +1,72 @@
+<?php
+
+declare(strict_types=1);
+
+// SPDX-FileCopyrightText: 2026 Dillard Blom
+// SPDX-License-Identifier: AGPL-3.0-or-later
+
+namespace OCA\NgBackup\BackgroundJob;
+
+use OCA\NgBackup\AppInfo\Application;
+use OCA\NgBackup\Db\RunMapper;
+use OCA\NgBackup\Service\BackupService;
+use OCA\NgBackup\Service\TargetService;
+use OCP\AppFramework\Utility\ITimeFactory;
+use OCP\BackgroundJob\IJob;
+use OCP\BackgroundJob\TimedJob;
+use OCP\IAppConfig;
+use Psr\Log\LoggerInterface;
+
+/**
+ * Starts scheduled backups and moves running ones forward, a time-boxed step per cron run.
+ * With system cron a step may take minutes; with webcron/AJAX cron it is kept short so it fits
+ * in a normal web request (hosted Nextcloud).
+ */
+class BackupJob extends TimedJob {
+	public function __construct(
+		ITimeFactory $time,
+		private BackupService $backups,
+		private TargetService $targets,
+		private RunMapper $runs,
+		private IAppConfig $appConfig,
+		private LoggerInterface $logger,
+	) {
+		parent::__construct($time);
+		$this->setInterval(300);
+		$this->setTimeSensitivity(IJob::TIME_SENSITIVE);
+	}
+
+	protected function run($argument): void {
+		$budget = PHP_SAPI === 'cli' ? 240.0 : 20.0;
+		$deadline = microtime(true) + $budget;
+		$this->startScheduled();
+		foreach ($this->runs->findRunning() as $run) {
+			while (microtime(true) < $deadline && $run->getStatus() === 'running') {
+				$run = $this->backups->step($run, min($deadline, microtime(true) + $budget));
+			}
+		}
+	}
+
+	/** Daily schedule: appconfig ng_backup/schedule_time "HH:MM" (server time); empty = no schedule. */
+	private function startScheduled(): void {
+		$at = $this->appConfig->getValueString(Application::APP_ID, 'schedule_time', '');
+		if (!preg_match('/^([01]\d|2[0-3]):[0-5]\d$/', $at)) {
+			return;
+		}
+		$todayAt = strtotime(date('Y-m-d') . ' ' . $at);
+		if (time() < $todayAt) {
+			return;
+		}
+		foreach ($this->targets->list() as $t) {
+			$last = $this->runs->lastFinished($t->getId(), BackupService::KIND_FULL);
+			if ($this->runs->findRunning($t->getId()) !== [] || ($last !== null && $last->getStartedAt() >= $todayAt)) {
+				continue;
+			}
+			try {
+				$this->backups->start($t, 'scheduled');
+			} catch (\Throwable $e) {
+				$this->logger->warning('NG Backup: scheduled backup to ' . $t->getName() . ' not started: ' . $e->getMessage());
+			}
+		}
+	}
+}