From 7b00d7ab9433fd93c11725e2e143d493af22f2c3 Mon Sep 17 00:00:00 2001 From: Dillard Blom Date: Thu, 1 Oct 2026 18:59:07 +0200 Subject: [PATCH] Docs: neutral wording for code review --- PLAN.md | 2 +- spikes/RESULTS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PLAN.md b/PLAN.md index d768a69..ffae555 100644 --- a/PLAN.md +++ b/PLAN.md @@ -297,7 +297,7 @@ niet met de hunne, maar bij installatie waarschuwen als `backup` ook actief is. machine met minder dan 1 GB vrije tijdelijke ruimte (tmpfs met limiet); meten dat er nooit meer dan één pack lokaal staat. - Psalm (niveau streng) tegen `nextcloud/ocp` van elke ondersteunde versie; geen private `OC\`-klassen. -- Reviews (Codex/CodeRabbit) per PR, zoals bij occweb. +- Code review per PR, zoals bij occweb. ## 7. Fasering en inschatting diff --git a/spikes/RESULTS.md b/spikes/RESULTS.md index 36fa049..27bf439 100644 --- a/spikes/RESULTS.md +++ b/spikes/RESULTS.md @@ -46,7 +46,7 @@ All spikes run on the standard `nextcloud:34-apache` image (PHP 8.5, sodium 1.0. - Restore of the database while Nextcloud is running (spike C restored with Nextcloud idle). - Schema introspection still uses the Doctrine connection behind `IDBConnection` (private API). -## Review (Codex + CodeRabbit, 2026-10-01) +## Code review (2026-10-01) No way was found to reorder or drop secretstream frames, substitute a blob, or decrypt with the wrong key/associated data without detection. Fixed after the review (all spikes re-run, all pass):