dillard
807353cbe4
RepositoryImportSource::copyToFolder() called putContent() on the generic return type of Node::get(), which doesn't declare that method -- only File does. Existing-file overwrite during a per-user restore would have fatally errored at runtime; added an instanceof check and a resource leak fix (finally-close) while there. Also guarded getFileAsStream() against fopen() returning false. Everything else Psalm (strict level) currently flags is mechanical (missing `final` on leaf classes -- applied everywhere safe) or pre-existing array-shape/type gaps, captured in psalm-baseline.xml so CI fails only on new issues from here on, not the whole backlog at once.
62 lines
1.9 KiB
PHP
62 lines
1.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
// SPDX-FileCopyrightText: 2026 Dillard Blom
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
namespace OCA\NgBackup\Service;
|
|
|
|
/**
|
|
* Passphrase slots (like LUKS): up to three passphrases, each opening the same master key, so
|
|
* that one person leaving or dying does not lock the company out of its backups. Every change
|
|
* is written to all locations and announced to all administrators; a new recovery kit must be
|
|
* downloaded and confirmed afterwards (backups keep running meanwhile).
|
|
*/
|
|
final class KeySlotService {
|
|
public function __construct(
|
|
private KeyService $keys,
|
|
private TargetService $targets,
|
|
private AlertService $alerts,
|
|
) {
|
|
}
|
|
|
|
public function add(#[\SensitiveParameter] string $passphrase, string $label): int {
|
|
$slot = $this->keys->addSlot($passphrase, $label);
|
|
$this->apply('slot_added', $slot);
|
|
return $slot;
|
|
}
|
|
|
|
public function replace(int $slot, #[\SensitiveParameter] string $passphrase, ?string $label = null): void {
|
|
$this->keys->replaceSlot($slot, $passphrase, $label);
|
|
$this->apply('slot_replaced', $slot);
|
|
}
|
|
|
|
public function remove(int $slot): void {
|
|
$this->keys->removeSlot($slot);
|
|
$this->apply('slot_removed', $slot);
|
|
}
|
|
|
|
private function apply(string $event, int $slot): void {
|
|
$wrapped = $this->keys->wrappedKey();
|
|
$failed = [];
|
|
foreach ($this->targets->list() as $t) {
|
|
try {
|
|
$this->targets->repository($t)->updateWrappedKey($wrapped);
|
|
} catch (\Throwable $e) {
|
|
$failed[] = $t->getName();
|
|
}
|
|
}
|
|
$label = '';
|
|
foreach ($this->keys->slots() as $s) {
|
|
if ($s['slot'] === $slot) {
|
|
$label = $s['label'];
|
|
}
|
|
}
|
|
$this->alerts->securityEvent($event, ['slot' => (string)$slot, 'label' => $label]);
|
|
if ($failed !== []) {
|
|
throw new \RuntimeException('Saved, but these locations could not be updated (they still accept the previous passphrases): ' . implode(', ', $failed));
|
|
}
|
|
}
|
|
}
|