The app store category cache (cache-categories) held the name and
description of every category in every language, about 170 KB, stored
as a regular app config value. Nextcloud loads all regular values of
all apps on every request, so this one value was read on every page
load. It was only refreshed with the "remove cache" button.
- Keep only the category ids and names, store the cache as a lazy
value so it is only loaded when categories are needed, and refresh
it after a week.
- Only load the categories where they are used: the menus with
categories, and the app list when custom categories are set.
- Save all settings in one request to a new admin endpoint, which
accepts only known settings, then clears the category cache and
changes the stylesheet cache key. The settings page sent one request
per setting and reloaded right after; with Nextcloud's short-lived
local config cache, the reloaded page could show a half-saved
configuration, so a change sometimes had to be made twice.
🔧 Problem: The Side Menu app was calling OC\Server::getAvatarManager(), which no longer exists in Nextcloud 32.
✅ Fix:
Injected IAvatarManager using Nextcloud’s public API instead of accessing it via OC::$server.
Updated the constructor to accept IAvatarManager, IUserSession, INavigationManager, and IURLGenerator.
Replaced all direct calls to OC::$server->getAvatarManager() and similar with the injected services.
This makes the app compatible with Nextcloud 32 and avoids deprecated internal method calls.
Signed-off-by: AndyXheli <andyxheli@gmail.com>
The current change is currently filling the nextcloud logs up with the error:
`Undefined array key \"HTTP_USER_AGENT\" at /srv/www/nextcloud/apps/side_menu/lib/AppInfo/Application.php#109`
This adds a check to ensure the index exists before read it.
dillard
Simon Vieille