fix links that must be opened in new window

appinfo/info.xml

@@ -21,11 +21,11 @@ If you like this application and want to support the development:
 ]]></description>
     <licence>agpl</licence>
     <author mail="contact@deblan.fr" homepage="https://www.deblan.io/">Simon Vieille</author>
-    <version>1.16.0</version>
+    <version>1.16.2</version>
     <namespace>SideMenu</namespace>
     <category>customization</category>
     <website>https://gitnet.fr/deblan/side_menu</website>
-    <discussion>https://deblan.cloud/index.php/call/fffxkc7h</discussion>
+    <discussion>https://matrix.to/#/!GhfQePnOSPYpYEunWM:neutralnetwork.org</discussion>
     <bugs>https://gitnet.fr/deblan/side_menu/issues</bugs>
     <repository type="git">https://gitnet.fr/deblan/side_menu</repository>
     <screenshot>https://gitnet.fr/deblan/side_menu/raw/branch/master/screenshots/nc19_default_menu.png</screenshot>

css/sideMenu.css

@@ -175,6 +175,16 @@
     color: var(--side-menu-text-color, #fff);
 }
 
+.side-menu-loader {
+    text-align: center;
+}
+
+.side-menu-loader svg {
+    width: 38px;
+    margin: auto;
+    stroke: var(--side-menu-text-color, #fff);
+}
+
 .side-menu-big .side-menu-app-icon {
     vertical-align: middle;
     margin-top: -2px;

img/loader.svg

@@ -0,0 +1,17 @@
+<!-- By Sam Herbert (@sherb), for everyone. More @ http://goo.gl/7AJzbL -->
+<svg width="38" height="38" viewBox="0 0 38 38" xmlns="http://www.w3.org/2000/svg" stroke="#fff">
+    <g fill="none" fill-rule="evenodd">
+        <g transform="translate(1 1)" stroke-width="2">
+            <circle stroke-opacity=".5" cx="18" cy="18" r="18"/>
+            <path d="M36 18c0-9.94-8.06-18-18-18">
+                <animateTransform
+                    attributeName="transform"
+                    type="rotate"
+                    from="0 18 18"
+                    to="360 18 18"
+                    dur="1s"
+                    repeatCount="indefinite"/>
+            </path>
+        </g>
+    </g>
+</svg>

lib/Controller/NavController.php

@@ -21,10 +21,12 @@ namespace OCA\SideMenu\Controller;
 use OC;
 use OC\App\AppStore\Fetcher\CategoryFetcher;
 use OC\URLGenerator;
+use OCA\SideMenu\AppInfo\Application;
 use OCA\SideMenu\Service\AppRepository;
 use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\JSONResponse;
+use OCP\IConfig;
 use OCP\IL10N;
 use OCP\IRequest;
 use OCP\IUserSession;
@@ -37,6 +39,11 @@ class NavController extends Controller
      */
     protected $config;
 
+    /**
+     * @var IConfig
+     */
+    protected $iConfig;
+
     /**
      * @var AppRepository
      */
@@ -60,6 +67,7 @@ class NavController extends Controller
     public function __construct(
         string $appName,
         IRequest $request,
+        IConfig $iConfig,
         ConfigProxy $config,
         AppRepository $appRepository,
         CategoryFetcher $categoryFetcher,
@@ -70,6 +78,7 @@ class NavController extends Controller
         parent::__construct($appName, $request);
 
         $this->config = $config;
+        $this->iConfig = $iConfig;
         $this->appRepository = $appRepository;
         $this->categoryFetcher = $categoryFetcher;
         $this->l10nFactory = $l10nFactory;
@@ -87,9 +96,9 @@ class NavController extends Controller
     {
         $apps = $this->appRepository->getVisibleApps();
         $currentLanguage = substr($this->l10nFactory->findLanguage(), 0, 2);
-        $categoriesLabels = $this->categoryFetcher->get();
         $externalSitesInTopMenu = $this->config->getAppValueBool('external-sites-in-top-menu', '0');
         $user = OC::$server[IUserSession::class]->getUser();
+        $isForced = $this->config->getAppValueBool('force', '0');
         $appsCategories = [];
         $categoriesAppsCount = [];
         $items = [];
@@ -100,10 +109,18 @@ class NavController extends Controller
             ]);
         }
 
+        $categoriesLabels = $this->config->getAppValueArray('cache-categories', '[]');
+
+        if (empty($categoriesLabels)) {
+            $categoriesLabels = $this->categoryFetcher->get();
+
+            $this->iConfig->setAppValue(Application::APP_ID, 'cache-categories', json_encode($categoriesLabels));
+        }
+
         $topMenuApps = $this->config->getAppValueArray('top-menu-apps', '[]');
         $userTopMenuApps = $this->config->getUserValueArray($user, 'top-menu-apps', '[]');
 
-        if (!empty($userTopMenuApps)) {
+        if (!$isForced && !empty($userTopMenuApps)) {
             $topMenuApps = $userTopMenuApps;
         }
 
@@ -135,7 +152,7 @@ class NavController extends Controller
             foreach ($categories as $category) {
                 if (!isset($items[$category])) {
                     $items[$category] = [
-                        'name' => $categoriesLabels[$category],
+                        'name' => $categoriesLabels[$category] ?? $category,
                         'apps' => [],
                     ];
                 }

lib/Controller/PersonalSettingController.php

@@ -29,14 +29,19 @@ use OCA\SideMenu\Service\ConfigProxy;
 class PersonalSettingController extends Controller
 {
     /**
-     * @var \OCP\IConfig
+     * @var IConfig
      */
     protected $config;
 
+    /**
+     * @var ConfigProxy
+     */
+    protected $configProxy;
+
     /**
      * @var IUserSession
      */
-    private $userSession;
+    protected $userSession;
 
     public function __construct($appName, IRequest $request, IConfig $config, ConfigProxy $configProxy, IUserSession $userSession)
     {

src/SideMenuBig.vue

@@ -23,6 +23,25 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 
         <div class="side-menu-categories-wrapper">
             <div class="side-menu-categories">
+                <div v-if="!items.length" class="side-menu-loader">
+                    <svg width="38" height="38" viewBox="0 0 38 38" xmlns="http://www.w3.org/2000/svg">
+                        <g fill="none" fill-rule="evenodd">
+                            <g transform="translate(1 1)" stroke-width="2">
+                                <circle stroke-opacity=".5" cx="18" cy="18" r="18"/>
+                                <path d="M36 18c0-9.94-8.06-18-18-18">
+                                    <animateTransform
+                                        attributeName="transform"
+                                        type="rotate"
+                                        from="0 18 18"
+                                        to="360 18 18"
+                                        dur="1s"
+                                        repeatCount="indefinite"/>
+                                </path>
+                            </g>
+                        </g>
+                    </svg>
+                </div>
+
                 <div class="side-menu-category" v-for="category in items">
                     <h2 class="side-menu-category-title" v-if="category.name != ''" v-html="category.name"></h2>
 

templates/js/_alwaysDisplayed.js

@@ -41,4 +41,28 @@ var alwaysDisplayed = function() {
     }
 }
 
-window.setTimeout(alwaysDisplayed, 200)
+let content = document.getElementById('content')
+
+if (content && content.classList.contains('app-settings')) {
+    let loaded = false
+    const config = {attributes: false, childList: true, subtree: true}
+    const observer = new MutationObserver(() => {
+        if (loaded) {
+            return;
+        }
+
+        const element = content.querySelector('#app-category-your-apps')
+            || content.querySelector('#app-navigation ul')
+
+        if (element) {
+            loaded = true
+
+            alwaysDisplayed()
+        }
+    })
+
+    observer.observe(content, config)
+} else {
+    window.setTimeout(alwaysDisplayed, 200)
+}
+

templates/js/_topMenuApps.js

@@ -108,6 +108,28 @@ var updateTopMenu = function() {
         k++
     })
 
+    // Hack for https://github.com/nextcloud/server/blob/23b0b63c213f5b31eecae817ffd4a9e26f6624d0/core/src/components/MainMenu.js#L74-L96
+    menu.undelegate('li:not(#more-apps) > a', 'click')
+    menu.delegate('li:not(#more-apps) > a', 'click', function(e) {
+        var a = $(e.target)
+
+        if (!a.is('a')) {
+            a = a.closest('a')
+        }
+
+        if (a.attr('target') !== '_blank' && e.which === 1 && !e.ctrlKey && !e.metaKey && a.parent('#more-apps').length === 0) {
+            a.find('svg').remove()
+            a.find('div').remove()
+            a.prepend(jQuery('<div/>').addClass(
+                OCA.Theming && OCA.Theming.inverted
+                ? 'icon-loading-small'
+                : 'icon-loading-small-dark'
+            ))
+
+            window.location.href = a.attr('href')
+        }
+    })
+
     jQuery('#apps li.app-external-site').each(function(i, app) {
         app = jQuery(app)
         var appId = app.attr('data-id')

templates/settings/admin-form.php

@@ -18,7 +18,6 @@
 
 script('side_menu', 'admin');
 style('side_menu', 'admin');
-style('side_menu', 'support');
 
 $choicesYesNo = [
     'No' => '0',

templates/settings/personal-form.php

@@ -18,7 +18,6 @@
 
 script('side_menu', 'admin');
 style('side_menu', 'admin');
-style('side_menu', 'support');
 
 $choicesYesNo = [
     'No' => '0',