Fix NC35 fatal in OccOutput, verify+narrow supported version range to 32-35
testbak/ (local, non-AIO docker compat rigs for NC32/33/34/35) found a real fatal on NC35: OccOutput::setErrorOutput() didn't declare the ": void" return type the Symfony Console version NC35 bundles now requires on ConsoleOutputInterface. Fixed by declaring it - compatible with older Symfony/NC versions too since it only narrows an untyped parent signature. 32/33 were also verified functional (the previously-suspected jQuery getter-conflict console exception on those versions is real but harmless - the app attaches via window.jQuery, not window.$). min-version/max-version narrowed from 30/34 to 32/35: 30/31 were never actually tested even before this session, so keeping them was an unverified claim; 35 is now genuinely verified rather than guessed.
This commit is contained in:
@@ -17,7 +17,12 @@ class OccOutput extends BufferedOutput implements ConsoleOutputInterface
|
||||
return $this;
|
||||
}
|
||||
|
||||
public function setErrorOutput(OutputInterface $error)
|
||||
// NC35 bundles a Symfony Console version whose ConsoleOutputInterface
|
||||
// declares this method `: void` - PHP 8 fatals ("Declaration must be
|
||||
// compatible") without a matching return type here. Declaring `: void`
|
||||
// is a valid narrowing of the untyped signature older Symfony/NC
|
||||
// versions have, so this stays compatible with NC30-34 too.
|
||||
public function setErrorOutput(OutputInterface $error): void
|
||||
{
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user