From 4b84be3cb73ee61cd526fb406af198169af1c6f8 Mon Sep 17 00:00:00 2001 From: Dillard Blom Date: Sat, 26 Sep 2026 17:18:26 +0200 Subject: [PATCH] Fix sixth Codex finding: check-clean-tree only guarded version, not source/appstore Running make appstore/source/dist directly (bypassing make version) still had the stale-archive risk check-clean-tree was added for: app_name/paths read from a dirty working tree while git archive HEAD packages the last commit. Added check-clean-tree as a prerequisite to source and appstore directly, not just transitively through version. --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 047fa00..5d4f1b1 100644 --- a/Makefile +++ b/Makefile @@ -134,14 +134,14 @@ check-app-name: (echo "app_name is empty - is 'xpath' (libxml2-utils/perl-XML-XPath) installed?" >&2; exit 1) .PHONY: source -source: check-app-name +source: check-app-name check-clean-tree rm -rf $(source_build_directory) mkdir -p $(source_build_directory) git archive --format=tar --prefix=$(app_name)/ HEAD | gzip > $(source_package_name).tar.gz # Builds the source package for the app store, ignores php and js tests .PHONY: appstore -appstore: check-app-name +appstore: check-app-name check-clean-tree rm -rf $(appstore_build_directory) mkdir -p $(appstore_build_directory) git archive --format=tar --prefix=$(app_name)/ HEAD | gzip > $(appstore_package_name).tar.gz