dillard
a5f5c5cdb7
- js/index.js: the occ-command ajax call used the wrong jQuery .fail() signature ((response, code) instead of (jqXHR, textStatus, errorThrown)), so any failure printed the literal string "[object Object]" instead of a useful message. - js/index.js: the initial bootstrap call that builds the terminal had no .fail() handler at all - a failure there (expired session/CSRF token, network error, rejected admin check) left #app-content permanently blank with zero diagnostic information. This is exactly what made today's NC34 debugging session harder than it needed to be; now it shows the actual HTTP status/reason in the page. - OccController.php: translated a leftover Dutch comment (missed by the earlier Russian->English pass since it wasn't Russian), and documented why requireAdmin() is intentional defense-in-depth rather than a misunderstanding of the framework: verified against Nextcloud's own SecurityMiddleware source that any controller method without @NoAdminRequired already rejects non-admins by default, so this check (and the original "security fix" commit that added it) was addressing a non-issue for THIS controller specifically. DbController's equivalent check is still genuinely load-bearing - that controller originally shipped with @PublicPage, which does bypass the default protection - so it gets a note explaining the distinction instead. - README: added compatibility matrix rows for 0.4.0 (app id rename to extended_occweb) and 0.4.1 (these fixes), both verified on NC 34.0.4. Deferred to when a test instance exists (tracked, not fixed here): no documented migration path from the old occweb id to extended_occweb for existing installs, OccController's constructor doing expensive work before the (redundant) admin check runs, and js/jquery.js loading unconditionally on NC30-33 where core still provides jQuery. Version bump to 0.4.1.
34 lines
1.5 KiB
XML
34 lines
1.5 KiB
XML
<?xml version="1.0"?>
|
|
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
|
|
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
|
|
<id>extended_occweb</id>
|
|
<name>Extended OCC Web</name>
|
|
<summary>OCC Commands in a web terminal</summary>
|
|
<description><![CDATA[Run OCC Commands in a web terminal]]></description>
|
|
<version>0.4.1</version>
|
|
<licence>agpl</licence>
|
|
<author mail="dillard.blom@ensembia.com" >Dillard Blom</author>
|
|
<namespace>OCCWeb</namespace>
|
|
<category>tools</category>
|
|
<website>https://github.com/dillardblom/occweb</website>
|
|
<bugs>https://github.com/dillardblom/occweb/issues</bugs>
|
|
<repository>https://github.com/dillardblom/occweb</repository>
|
|
<screenshot>https://github.com/dillardblom/occweb/raw/main/appinfo/screenshot.png</screenshot>
|
|
<dependencies>
|
|
<!-- max-version must equal the highest NC core version this fork has
|
|
actually been verified on - never a value inherited from upstream
|
|
or guessed ahead. Test against the next major's beta and bump
|
|
this BEFORE it goes final, so occ:upgrade never has to fall back
|
|
to auto-disabling the app. -->
|
|
<nextcloud min-version="30" max-version="34"/>
|
|
</dependencies>
|
|
<navigations>
|
|
<navigation role="admin">
|
|
<name>OCC Web</name>
|
|
<route>extended_occweb.occ.index</route>
|
|
<icon>app.svg</icon>
|
|
<type>link</type>
|
|
</navigation>
|
|
</navigations>
|
|
</info>
|