release v1.2.1

README.md

@@ -38,3 +38,13 @@ $ unzip -d side_menu /path/to/side_menu_vX.Y.Z.zip
 ![](https://upload.deblan.org/u/2020-03/5e81b219.jpg)
 
 ![](https://upload.deblan.org/u/2020-04/5e8ee1f7.jpg)
+
+
+How to contribute?
+------------------
+
+Fork the repository, go to `apps/`, clone your repository and run `npm install` inside.
+
+Build javascripts using `webpack --config ./webpack.js` (add `-w` to build them in real time).
+
+Then commit and create a pull request.

appinfo/info.xml

@@ -6,7 +6,7 @@
     <description>Move the top menu to the left side.</description>
     <licence>agpl</licence>
     <author mail="dev+sidemenu@deblan.fr" homepage="https://www.deblan.io/">Simon Vieille</author>
-    <version>1.1.3</version>
+    <version>1.2.1</version>
     <namespace>SideMenu</namespace>
     <category>customization</category>
     <website>https://gitnet.fr/deblan/side_menu</website>

css/sideMenu.css

@@ -33,7 +33,7 @@
     display: none;
 }
 
-#side-menu.is-active {
+#side-menu.open {
     display: block;
 }
 
@@ -71,7 +71,7 @@
     white-space: nowrap;
 }
 
-.side-menu-app a:hover, .side-menu-app.is-active a {
+.side-menu-app a:hover, .side-menu-app.active a {
     background: var(--side-menu-current-app-background-color, #444);
 }
 

lib/Settings/Admin.php

@@ -35,7 +35,8 @@ class Admin implements ISettings
     /** @var IConfig */
     private $config;
 
-    public function __construct(IL10N $l, ILogger $logger, IConfig $config) {
+    public function __construct(IL10N $l, ILogger $logger, IConfig $config)
+    {
         $this->l = $l;
         $this->logger = $logger;
         $this->config = $config;

lib/Settings/Section.php

@@ -79,6 +79,6 @@ class Section implements IIconSection
      */
     public function getIcon()
     {
-		return $this->url->imagePath('theming', 'app-dark.svg');
+        return $this->url->imagePath('theming', 'app-dark.svg');
     }
 }

src/SideMenu.js

@@ -18,13 +18,12 @@
 import Vue from 'vue'
 import SideMenu from './SideMenu.vue'
 
-Vue.prototype.t = t
-Vue.prototype.OC = OC
-Vue.prototype.OC = OCP
+// Vue.prototype.t = t
+// Vue.prototype.OC = OC
+// Vue.prototype.OC = OCP
 
 const View = Vue.extend(SideMenu)
-const sideMenu = new View({
-})
+const sideMenu = new View({})
 
 const mountSideMenuComponent = () => {
     const sideMenuContainer = document.querySelector('#side-menu')

src/SideMenu.vue

@@ -25,7 +25,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
         </div>
 
         <ul class="side-menu-apps-list">
-            <li v-for="app in apps" v-bind:class="{'side-menu-app': true, 'is-active': app.active}">
+            <li v-for="app in apps" v-bind:class="{'side-menu-app': true, 'active': app.active}">
                 <a v-bind:href="app.href">
                      <span class="side-menu-app-icon" v-html="app.icon"></span>
 
@@ -37,9 +37,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 </template>
 
 <script>
-import axios from '@nextcloud/axios'
-import { generateUrl } from '@nextcloud/router'
-
 export default {
     name: 'SideMenu',
     data() {
@@ -67,10 +64,14 @@ export default {
             }
         },
         retrieveLogo() {
-            this.logo = window.getComputedStyle(document.querySelector('#nextcloud .logo'), null)
-                .getPropertyValue('background-image')
-                .replace('url("', '')
-                .replace('")', '')
+			const ncLogo = document.querySelector('#nextcloud .logo')
+
+			if (ncLogo) {
+				this.logo = window.getComputedStyle(ncLogo, null)
+					.getPropertyValue('background-image')
+					.replace('url("', '')
+					.replace('")', '')
+			}
         },
     },
     created() {

src/admin.js

@@ -42,7 +42,7 @@ const saveSettings = (key) => {
                 t('side_menu', (key + 1) + '/' + size)
             )
 
-            if (key < size -1) {
+            if (key < size - 1) {
                 saveSettings(++key)
             } else {
                 OC.msg.finishedSuccess(selector, t('side_menu', 'Saved'))
@@ -55,10 +55,10 @@ const saveSettings = (key) => {
 }
 
 $(document).ready(() => {
-	$('#side-menu-save').on('click', (event) => {
-		event.preventDefault()
-		OC.msg.startSaving(selector)
+    $('#side-menu-save').on('click', (event) => {
+        event.preventDefault()
+        OC.msg.startSaving(selector)
 
         saveSettings(0)
-	});
+    });
 });

src/main.js

@@ -15,13 +15,16 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-const sideMenuContainer = $('<div id="side-menu">')
+const sideMenuContainer = $('<div id="side-menu-container">')
 const sideMenuOpener = $('<button class="side-menu-opener"></button>')
+const sideMenu = $('<div id="side-menu">')
+
+sideMenuContainer.append(sideMenu);
 
 $('body').append(sideMenuContainer);
 
 sideMenuOpener.insertBefore('#nextcloud');
 
 $('body').on('click', '.side-menu-opener', () => {
-    $('#side-menu').toggleClass('is-active');
+    $('#side-menu').toggleClass('open');
 })