Revert max-version to 33: only claim what we've actually verified
35 was fanategorius's own tested value, but this is now a modified fork (CSRF fix, admin checks, translated internals) - inheriting their compatibility claim isn't the same as having verified it ourselves. 33 is the only version this fork has actually run on (nc01). An untested max-version that's too high is worse than one that's accurate: on the next core bump, Nextcloud's own compat check would keep the app enabled on an unverified major instead of cleanly disabling it, so a real incompatibility would surface as a runtime error instead of a safe, expected "needs testing" disable. Policy going forward (documented inline in info.xml): test against the next major's beta ahead of time and bump max-version before that major goes final, so the app is never caught by surprise - never bump it reactively/speculatively.
This commit is contained in:
+6
-1
@@ -15,7 +15,12 @@
|
||||
<repository>https://github.com/dillardblom/occweb</repository>
|
||||
<screenshot>https://github.com/dillardblom/occweb/raw/main/appinfo/screenshot.png</screenshot>
|
||||
<dependencies>
|
||||
<nextcloud min-version="30" max-version="35"/>
|
||||
<!-- max-version must equal the highest NC core version this fork has
|
||||
actually been verified on - never a value inherited from upstream
|
||||
or guessed ahead. Test against the next major's beta and bump
|
||||
this BEFORE it goes final, so occ:upgrade never has to fall back
|
||||
to auto-disabling the app. -->
|
||||
<nextcloud min-version="30" max-version="33"/>
|
||||
</dependencies>
|
||||
<navigations>
|
||||
<navigation role="admin">
|
||||
|
||||
Reference in New Issue
Block a user