release v1.14.0

- add a controller to retrieve most of the configuration

appinfo/info.xml

@@ -14,8 +14,6 @@ Comptatible with AppOrder.
 
 You can report a bug or request a feature by opening an issue.
 
-If you like this app, leave a review on https://apps.nextcloud.com/apps/side_menu
-
 You like this app and you want to support me?
 
 * ☕ [Buy me a coffee](https://www.buymeacoffee.com/deblan)
@@ -23,7 +21,7 @@ You like this app and you want to support me?
 ]]></description>
     <licence>agpl</licence>
     <author mail="contact@deblan.fr" homepage="https://www.deblan.io/">Simon Vieille</author>
-    <version>1.13.0</version>
+    <version>1.14.0</version>
     <namespace>SideMenu</namespace>
     <category>customization</category>
     <website>https://gitnet.fr/deblan/side_menu</website>

appinfo/routes.php

@@ -21,6 +21,7 @@ return [
     'routes' => [
 		['name' => 'Css#stylesheet', 'url' => '/css/stylesheet', 'verb' => 'GET'],
 		['name' => 'Js#script', 'url' => '/js/script', 'verb' => 'GET'],
+		['name' => 'Js#config', 'url' => '/js/config', 'verb' => 'GET'],
 		['name' => 'Nav#items', 'url' => '/nav/items', 'verb' => 'GET'],
 		['name' => 'PersonalSetting#valueSet', 'url' => '/personalSetting/valueSet', 'verb' => 'POST'],
     ],

lib/AppInfo/Application.php

@@ -6,6 +6,7 @@ use OC;
 use OC\Security\CSP\ContentSecurityPolicyNonceManager;
 use OC\User\User;
 use OCA\SideMenu\Service\AppRepository;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\App;
 use OCP\IUserSession;
 use OCP\Util;
@@ -18,6 +19,9 @@ use Psr\Container\ContainerInterface;
  */
 class Application extends App
 {
+    public const APP_ID = 'side_menu';
+
+    public const APP_NAME = 'Side menu';
     /**
      * @var OC\AllConfig
      */
@@ -38,7 +42,7 @@ class Application extends App
      */
     public function __construct(array $urlParams = [])
     {
-        parent::__construct('side_menu', $urlParams);
+        parent::__construct(self::APP_ID, $urlParams);
 
         $this->config = OC::$server->getConfig();
         $this->cspnm = OC::$server->getContentSecurityPolicyNonceManager();
@@ -53,7 +57,7 @@ class Application extends App
         $enabled = true;
 
         if (null !== $this->user) {
-            $enabled = (bool) $this->config->getUserValue($this->user->getUid(), 'side_menu', 'enabled', '1');
+            $enabled = (bool) $this->config->getUserValue($this->user->getUid(), self::APP_ID, 'enabled', '1');
         }
 
         return $enabled;
@@ -69,6 +73,10 @@ class Application extends App
         $container->registerService('AppRepository', function (ContainerInterface $c) {
             return new AppRepository(new OC_App());
         });
+
+        $container->registerService('ConfigProxy', function (ContainerInterface $c) {
+            return new ConfigProxy($this->config);
+        });
     }
 
     /**
@@ -76,20 +84,20 @@ class Application extends App
      */
     public function registerAssets()
     {
-        Util::addScript('side_menu', 'sideMenu');
-        Util::addStyle('side_menu', 'sideMenu');
+        Util::addScript(self::APP_ID, 'sideMenu');
+        Util::addStyle(self::APP_ID, 'sideMenu');
 
         $stylesheet = OC::$server->getURLGenerator()->linkToRoute(
             'side_menu.Css.stylesheet',
             [
-                'v' => $this->config->getAppValue('side_menu', 'cache', '0'),
+                'v' => $this->config->getAppValue(self::APP_ID, 'cache', '0'),
             ]
         );
 
         $script = OC::$server->getURLGenerator()->linkToRoute(
             'side_menu.Js.script',
             [
-                'v' => $this->config->getAppValue('side_menu', 'cache', '0'),
+                'v' => $this->config->getAppValue(self::APP_ID, 'cache', '0'),
             ]
         );
 

lib/Controller/CssController.php

@@ -19,27 +19,32 @@
 namespace OCA\SideMenu\Controller;
 
 use OC;
+use OC\User\User;
+use OCA\SideMenu\AppInfo\Application;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\Response;
 use OCP\AppFramework\Http\TemplateResponse;
-use OCP\IConfig;
 use OCP\IRequest;
 use OCP\IUserSession;
 
 class CssController extends Controller
 {
     /**
-     * @var \OCP\IConfig
+     * @var ConfigProxy
      */
     protected $config;
 
     /**
-     * @param string $appName
+     * @var User
      */
-    public function __construct($appName, IRequest $request, IConfig $config)
+    protected $user;
+
+    public function __construct(string $appName, IRequest $request, ConfigProxy $config)
     {
         parent::__construct($appName, $request);
 
+        $this->user = OC::$server[IUserSession::class]->getUser();
         $this->config = $config;
     }
 
@@ -52,44 +57,46 @@ class CssController extends Controller
      */
     public function stylesheet()
     {
-        $backgroundColor = $this->config->getAppValue('side_menu', 'background-color', '#333333');
-        $backgroundColorTo = $this->config->getAppValue('side_menu', 'background-color-to', $backgroundColor);
+        $response = new TemplateResponse(Application::APP_ID, 'css/stylesheet', $this->getConfig(), 'blank');
+        $response->addHeader('Content-Type', 'text/css');
 
-        $user = OC::$server[IUserSession::class]->getUser();
-        $topMenuApps = (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true);
+        return $response;
+    }
 
-        if ($user) {
-            $userTopMenuApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true);
+    protected function getConfig(): array
+    {
+        $backgroundColor = $this->config->getAppValue('background-color', '#333333');
+        $backgroundColorTo = $this->config->getAppValue('background-color-to', $backgroundColor);
+
+        $topMenuApps = $this->config->getAppValueArray('top-menu-apps', '[]');
+
+        if ($this->user) {
+            $userTopMenuApps = $this->config->getUserValueArray($this->user, 'top-menu-apps', '[]');
 
             if (!empty($userTopMenuApps)) {
                 $topMenuApps = $userTopMenuApps;
             }
         }
 
-        $parameters = [
+        return [
             'vars' => [
                 'background-color' => $backgroundColor,
                 'background-color-to' => $backgroundColorTo,
-                'current-app-background-color' => $this->config->getAppValue('side_menu', 'current-app-background-color', '#444444'),
-                'loader-color' => $this->config->getAppValue('side_menu', 'loader-color', '#0e75ac'),
-                'text-color' => $this->config->getAppValue('side_menu', 'text-color', '#FFFFFF'),
-                'opener' => $this->config->getAppValue('side_menu', 'opener', 'side-menu-opener'),
-                'icon-invert-filter' => abs((int) $this->config->getAppValue('side_menu', 'icon-invert-filter', '0')).'%',
-                'icon-opacity' => abs((int) $this->config->getAppValue('side_menu', 'icon-opacity', '100') / 100),
+                'current-app-background-color' => $this->config->getAppValue('current-app-background-color', '#444444'),
+                'loader-color' => $this->config->getAppValue('loader-color', '#0e75ac'),
+                'text-color' => $this->config->getAppValue('text-color', '#FFFFFF'),
+                'opener' => $this->config->getAppValue('opener', 'side-menu-opener'),
+                'icon-invert-filter' => abs($this->config->getAppValueInt('icon-invert-filter', '0')).'%',
+                'icon-opacity' => abs($this->config->getAppValueInt('icon-opacity', '100') / 100),
             ],
-            'display-logo' => (bool) $this->config->getAppValue('side_menu', 'display-logo', 1),
-            'opener-only' => (bool) $this->config->getAppValue('side_menu', 'opener-only', 0),
-            'external-sites-in-top-menu' => (bool) $this->config->getAppValue('side_menu', 'external-sites-in-top-menu', 0),
-            'size-icon' => $this->config->getAppValue('side_menu', 'size-icon', 'normal'),
-            'size-text' => $this->config->getAppValue('side_menu', 'size-text', 'normal'),
-            'always-displayed' => (bool) $this->config->getAppValue('side_menu', 'always-displayed', '0'),
-            'big-menu' => (bool) $this->config->getAppValue('side_menu', 'big-menu', '0'),
+            'display-logo' => $this->config->getAppValueBool('display-logo', 1),
+            'opener-only' => $this->config->getAppValueBool('opener-only', 0),
+            'external-sites-in-top-menu' => $this->config->getAppValueBool('external-sites-in-top-menu', 0),
+            'size-icon' => $this->config->getAppValue('size-icon', 'normal'),
+            'size-text' => $this->config->getAppValue('size-text', 'normal'),
+            'always-displayed' => $this->config->getAppValueBool('always-displayed', '0'),
+            'big-menu' => $this->config->getAppValueBool('big-menu', '0'),
             'top-menu-apps' => $topMenuApps,
         ];
-
-        $response = new TemplateResponse('side_menu', 'css/stylesheet', $parameters, 'blank');
-        $response->addHeader('Content-Type', 'text/css');
-
-        return $response;
     }
 }

lib/Controller/JsController.php

@@ -19,27 +19,40 @@
 namespace OCA\SideMenu\Controller;
 
 use OC;
+use OC\User\User;
+use OCA\SideMenu\AppInfo\Application;
+use OCA\SideMenu\Service\ConfigProxy;
+use OCA\Theming\ThemingDefaults;
 use OCP\AppFramework\Controller;
-use OCP\AppFramework\Http\Response;
+use OCP\AppFramework\Http\JSONResponse;
 use OCP\AppFramework\Http\TemplateResponse;
-use OCP\IConfig;
 use OCP\IRequest;
 use OCP\IUserSession;
 
 class JsController extends Controller
 {
     /**
-     * @var \OCP\IConfig
+     * @var ConfigProxy
      */
     protected $config;
 
     /**
-     * @param string $appName
+     * @var User
      */
-    public function __construct($appName, IRequest $request, IConfig $config)
+    protected $user;
+
+    /**
+     * @var ThemingDefaults
+     */
+    protected $themingDefaults;
+
+    public function __construct(string $appName, IRequest $request, ConfigProxy $config, ThemingDefaults $themingDefaults)
     {
         parent::__construct($appName, $request);
 
+        $this->themingDefaults = $themingDefaults;
+
+        $this->user = OC::$server[IUserSession::class]->getUser();
         $this->config = $config;
     }
 
@@ -47,61 +60,72 @@ class JsController extends Controller
      * @NoAdminRequired
      * @NoCSRFRequired
      * @PublicPage
-     *
-     * @return Response
      */
-    public function script()
+    public function script(): TemplateResponse
     {
-        $user = OC::$server[IUserSession::class]->getUser();
-        $topMenuApps = (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true);
-        $targetBlankApps = (array) json_decode($this->config->getAppValue('side_menu', 'target-blank-apps', '[]'), true);
-        $useAvatar = (bool) $this->config->getAppValue('side_menu', 'use-avatar', '0');
+        $response = new TemplateResponse(Application::APP_ID, 'js/script', $this->getConfig(), 'blank');
+        $response->addHeader('Content-Type', 'text/javascript');
+
+        return $response;
+    }
+
+    /**
+     * @NoAdminRequired
+     * @NoCSRFRequired
+     * @PublicPage
+     */
+    public function config(): JSONResponse
+    {
+        return new JSONResponse($this->getConfig());
+    }
+
+    protected function getConfig(): array
+    {
+        $topMenuApps = $this->config->getAppValueArray('top-menu-apps', '[]');
+        $targetBlankApps = $this->config->getAppValueArray('target-blank-apps', '[]');
+        $useAvatar = $this->config->getAppValueBool('use-avatar', '0');
         $avatar = null;
 
-        if ($user) {
-            $userTopMenuApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true);
+        if ($this->user) {
+            $userTopMenuApps = $this->config->getUserValueArray($this->user, 'top-menu-apps', '[]');
 
             if (!empty($userTopMenuApps)) {
                 $topMenuApps = $userTopMenuApps;
             }
 
-            $userTargetBlankMode = (int) $this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-mode', '1');
-            $userTargetBlankApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-apps', '[]'), true);
+            $userTargetBlankMode = $this->config->getUserValueInt($this->user, 'target-blank-mode', '1');
+            $userTargetBlankApps = $this->config->getUserValueArray($this->user, 'target-blank-apps', '[]');
 
             if (2 === $userTargetBlankMode) {
                 $targetBlankApps = $userTargetBlankApps;
             }
 
-            $isAvatarSet = OC::$server->getAvatarManager()->getAvatar($user->getUid())->exists();
+            $isAvatarSet = OC::$server->getAvatarManager()->getAvatar($this->user->getUid())->exists();
 
             if ($useAvatar && $isAvatarSet) {
                 $avatar = OC::$server->getURLGenerator()->linkToRoute(
                     'core.avatar.getAvatar', [
-                        'userId' => $user->getUid(),
+                        'userId' => $this->user->getUid(),
                         'size' => 128,
-                        'v' => $this->config->getUserValue($user, 'avatar', 'version', 0),
+                        'v' => $this->config->getUserValueInt($this->user, 'avatar', 'version', 0),
                     ]
                 );
             }
         }
 
-        $parameters = [
-            'opener-position' => $this->config->getAppValue('side_menu', 'opener-position', 'before'),
-            'opener-hover' => (bool) $this->config->getAppValue('side_menu', 'opener-hover', '0'),
-            'external-sites-in-top-menu' => (bool) $this->config->getAppValue('side_menu', 'external-sites-in-top-menu', 0),
-            'force-light-icon' => (bool) $this->config->getAppValue('side_menu', 'force-light-icon', '0'),
-            'hide-when-no-apps' => (bool) $this->config->getAppValue('side_menu', 'hide-when-no-apps', '0'),
-            'loader-enabled' => (bool) $this->config->getAppValue('side_menu', 'loader-enabled', '1'),
-            'always-displayed' => (bool) $this->config->getAppValue('side_menu', 'always-displayed', '0'),
-            'big-menu' => (bool) $this->config->getAppValue('side_menu', 'big-menu', '0'),
+        return [
+            'opener-position' => $this->config->getAppValue('opener-position', 'before'),
+            'opener-hover' => $this->config->getAppValueBool('opener-hover', '0'),
+            'external-sites-in-top-menu' => $this->config->getAppValueBool('external-sites-in-top-menu', 0),
+            'force-light-icon' => $this->config->getAppValueBool('force-light-icon', '0'),
+            'hide-when-no-apps' => $this->config->getAppValueBool('hide-when-no-apps', '0'),
+            'loader-enabled' => $this->config->getAppValueBool('loader-enabled', '1'),
+            'always-displayed' => $this->config->getAppValueBool('always-displayed', '0'),
+            'big-menu' => $this->config->getAppValueBool('big-menu', '0'),
             'avatar' => $avatar,
             'top-menu-apps' => $topMenuApps,
             'target-blank-apps' => $targetBlankApps,
+            'logo' => $this->themingDefaults->getLogo(),
         ];
-
-        $response = new TemplateResponse('side_menu', 'js/script', $parameters, 'blank');
-        $response->addHeader('Content-Type', 'text/javascript');
-
-        return $response;
     }
 }

lib/Controller/NavController.php

@@ -22,9 +22,9 @@ use OC;
 use OC\App\AppStore\Fetcher\CategoryFetcher;
 use OC\URLGenerator;
 use OCA\SideMenu\Service\AppRepository;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\JSONResponse;
-use OCP\IConfig;
 use OCP\IL10N;
 use OCP\IRequest;
 use OCP\IUserSession;
@@ -33,7 +33,7 @@ use OCP\L10N\IFactory;
 class NavController extends Controller
 {
     /**
-     * @var IConfig
+     * @var ConfigProxy
      */
     protected $config;
 
@@ -57,13 +57,10 @@ class NavController extends Controller
      */
     protected $router;
 
-    /**
-     * @param string $appName
-     */
     public function __construct(
-        $appName,
+        string $appName,
         IRequest $request,
-        IConfig $config,
+        ConfigProxy $config,
         AppRepository $appRepository,
         CategoryFetcher $categoryFetcher,
         URLGenerator $router,
@@ -91,7 +88,7 @@ class NavController extends Controller
         $apps = $this->appRepository->getVisibleApps();
         $currentLanguage = substr($this->l10nFactory->findLanguage(), 0, 2);
         $categoriesLabels = $this->categoryFetcher->get();
-        $externalSitesInTopMenu = (bool) $this->config->getAppValue('side_menu', 'external-sites-in-top-menu', 0);
+        $externalSitesInTopMenu = $this->config->getAppValueBool('external-sites-in-top-menu', 0);
         $user = OC::$server[IUserSession::class]->getUser();
         $appsCategories = [];
         $categoriesAppsCount = [];
@@ -103,8 +100,8 @@ class NavController extends Controller
             ]);
         }
 
-        $topMenuApps = (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true);
-        $userTopMenuApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true);
+        $topMenuApps = $this->config->getAppValueArray('top-menu-apps', '[]');
+        $userTopMenuApps = $this->config->getUserValueArray($user, 'top-menu-apps', '[]');
 
         if (!empty($userTopMenuApps)) {
             $topMenuApps = $userTopMenuApps;

lib/Controller/PersonalSettingController.php

@@ -23,6 +23,7 @@ use OCP\AppFramework\Http\Response;
 use OCP\IConfig;
 use OCP\IRequest;
 use OCP\IUserSession;
+use OCA\SideMenu\AppInfo\Application;
 
 class PersonalSettingController extends Controller
 {
@@ -104,7 +105,7 @@ class PersonalSettingController extends Controller
         }
 
         if ($doSave) {
-            $this->config->setUserValue($user->getUid(), 'side_menu', $name, $value);
+            $this->config->setUserValue($user->getUid(), Application::APP_ID, $name, $value);
 
             return [
                 'name' => $name,

lib/Service/ConfigProxy.php

@@ -0,0 +1,65 @@
+<?php
+
+namespace OCA\SideMenu\Service;
+
+use OC\User\User;
+use OCA\SideMenu\AppInfo\Application;
+use OCP\IConfig;
+
+/**
+ * class Config.
+ *
+ * @author Simon Vieille <simon@deblan.fr>
+ */
+class ConfigProxy
+{
+    /**
+     * @var IConfig
+     */
+    protected $config;
+
+    public function __construct(IConfig $config)
+    {
+        $this->config = $config;
+    }
+
+    public function getAppValue(string $name, string $default): string
+    {
+        return (string) $this->config->getAppValue(Application::APP_ID, $name, $default);
+    }
+
+    public function getUserValue(User $user, string $name, string $default): string
+    {
+        return (string) $this->config->getUserValue($user->getUid(), Application::APP_ID, $name, $default);
+    }
+
+    public function getAppValueBool(string $name, string $default): bool
+    {
+        return (bool) $this->getAppValue($name, $default);
+    }
+
+    public function getAppValueArray(string $name, string $default): array
+    {
+        return (array) json_decode($this->getAppValue($name, $default), true);
+    }
+
+    public function getAppValueInt(string $name, string $default): int
+    {
+        return (int) $this->getAppValue($name, $default);
+    }
+
+    public function getUserValueBool(User $user, string $name, string $default): bool
+    {
+        return (bool) $this->getUserValue($user, $name, $default);
+    }
+
+    public function getUserValueArray(User $user, string $name, string $default): array
+    {
+        return (array) json_decode($this->getUserValue($user, $name, $default), true);
+    }
+
+    public function getUserValueInt(User $user, string $name, string $default): int
+    {
+        return (int) $this->getUserValue($user, $name, $default);
+    }
+}

lib/Settings/Admin.php

@@ -24,6 +24,7 @@ use OCP\IConfig;
 use OCP\IL10N;
 use OCP\ILogger;
 use OCP\Settings\ISettings;
+use OCA\SideMenu\AppInfo\Application;
 
 class Admin implements ISettings
 {
@@ -60,36 +61,36 @@ class Admin implements ISettings
      */
     public function getForm()
     {
-        $backgroundColor = $this->config->getAppValue('side_menu', 'background-color', '#333333');
-        $backgroundColorTo = $this->config->getAppValue('side_menu', 'background-color-to', $backgroundColor);
+        $backgroundColor = $this->config->getAppValue(Application::APP_ID, 'background-color', '#333333');
+        $backgroundColorTo = $this->config->getAppValue(Application::APP_ID, 'background-color-to', $backgroundColor);
 
         $parameters = [
             'background-color' => $backgroundColor,
             'background-color-to' => $backgroundColorTo,
-            'current-app-background-color' => $this->config->getAppValue('side_menu', 'current-app-background-color', '#444444'),
-            'loader-color' => $this->config->getAppValue('side_menu', 'loader-color', '#0e75ac'),
-            'icon-invert-filter' => (int) $this->config->getAppValue('side_menu', 'icon-invert-filter', '0'),
-            'icon-opacity' => (int) $this->config->getAppValue('side_menu', 'icon-opacity', '100'),
-            'loader-enabled' => $this->config->getAppValue('side_menu', 'loader-enabled', '1'),
-            'text-color' => $this->config->getAppValue('side_menu', 'text-color', '#FFFFFF'),
-            'cache' => $this->config->getAppValue('side_menu', 'cache', '0'),
-            'opener' => $this->config->getAppValue('side_menu', 'opener', 'side-menu-opener'),
-            'always-displayed' => $this->config->getAppValue('side_menu', 'always-displayed', '0'),
-            'big-menu' => $this->config->getAppValue('side_menu', 'big-menu', '0'),
-            'display-logo' => $this->config->getAppValue('side_menu', 'display-logo', '1'),
-            'use-avatar' => $this->config->getAppValue('side_menu', 'use-avatar', '0'),
-            'opener-position' => $this->config->getAppValue('side_menu', 'opener-position', 'before'),
-            'opener-hover' => $this->config->getAppValue('side_menu', 'opener-hover', '0'),
-            'opener-only' => $this->config->getAppValue('side_menu', 'opener-only', '0'),
-            'hide-when-no-apps' => $this->config->getAppValue('side_menu', 'hide-when-no-apps', '0'),
-            'size-icon' => $this->config->getAppValue('side_menu', 'size-icon', 'normal'),
-            'size-text' => $this->config->getAppValue('side_menu', 'size-text', 'normal'),
-            'target-blank-apps' => (array) json_decode($this->config->getAppValue('side_menu', 'target-blank-apps', '[]'), true),
-            'top-menu-apps' => (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true),
+            'current-app-background-color' => $this->config->getAppValue(Application::APP_ID, 'current-app-background-color', '#444444'),
+            'loader-color' => $this->config->getAppValue(Application::APP_ID, 'loader-color', '#0e75ac'),
+            'icon-invert-filter' => (int) $this->config->getAppValue(Application::APP_ID, 'icon-invert-filter', '0'),
+            'icon-opacity' => (int) $this->config->getAppValue(Application::APP_ID, 'icon-opacity', '100'),
+            'loader-enabled' => $this->config->getAppValue(Application::APP_ID, 'loader-enabled', '1'),
+            'text-color' => $this->config->getAppValue(Application::APP_ID, 'text-color', '#FFFFFF'),
+            'cache' => $this->config->getAppValue(Application::APP_ID, 'cache', '0'),
+            'opener' => $this->config->getAppValue(Application::APP_ID, 'opener', 'side-menu-opener'),
+            'always-displayed' => $this->config->getAppValue(Application::APP_ID, 'always-displayed', '0'),
+            'big-menu' => $this->config->getAppValue(Application::APP_ID, 'big-menu', '0'),
+            'display-logo' => $this->config->getAppValue(Application::APP_ID, 'display-logo', '1'),
+            'use-avatar' => $this->config->getAppValue(Application::APP_ID, 'use-avatar', '0'),
+            'opener-position' => $this->config->getAppValue(Application::APP_ID, 'opener-position', 'before'),
+            'opener-hover' => $this->config->getAppValue(Application::APP_ID, 'opener-hover', '0'),
+            'opener-only' => $this->config->getAppValue(Application::APP_ID, 'opener-only', '0'),
+            'hide-when-no-apps' => $this->config->getAppValue(Application::APP_ID, 'hide-when-no-apps', '0'),
+            'size-icon' => $this->config->getAppValue(Application::APP_ID, 'size-icon', 'normal'),
+            'size-text' => $this->config->getAppValue(Application::APP_ID, 'size-text', 'normal'),
+            'target-blank-apps' => (array) json_decode($this->config->getAppValue(Application::APP_ID, 'target-blank-apps', '[]'), true),
+            'top-menu-apps' => (array) json_decode($this->config->getAppValue(Application::APP_ID, 'top-menu-apps', '[]'), true),
             'apps' => $this->appRepository->getVisibleApps(),
         ];
 
-        return new TemplateResponse('side_menu', 'settings/admin-form', $parameters, '');
+        return new TemplateResponse(Application::APP_ID, 'settings/admin-form', $parameters, '');
     }
 
     /**
@@ -97,7 +98,7 @@ class Admin implements ISettings
      */
     public function getSection()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**

lib/Settings/AdminSection.php

@@ -21,6 +21,7 @@ namespace OCA\SideMenu\Settings;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 use OCP\Settings\IIconSection;
+use OCA\SideMenu\AppInfo\Application;
 
 class AdminSection implements IIconSection
 {
@@ -52,7 +53,7 @@ class AdminSection implements IIconSection
      */
     public function getID()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**
@@ -63,7 +64,7 @@ class AdminSection implements IIconSection
      */
     public function getName()
     {
-        return $this->l->t('Side menu');
+        return $this->l->t(Application::APP_NAME);
     }
 
     /**

lib/Settings/Personal.php

@@ -25,6 +25,7 @@ use OCP\Settings\ISettings;
 use OCP\IConfig;
 use OCP\IUserSession;
 use OCA\SideMenu\Service\AppRepository;
+use OCA\SideMenu\AppInfo\Application;
 
 class Personal implements ISettings
 {
@@ -70,14 +71,14 @@ class Personal implements ISettings
         $user = $this->userSession->getUser();
 
         $parameters = [
-            'enabled' => $this->config->getUserValue($user->getUid(), 'side_menu', 'enabled', '1'),
-            'top-menu-apps' => (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true),
-            'target-blank-mode' => $this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-mode', '1'),
-            'target-blank-apps' => (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-apps', '[]'), true),
+            'enabled' => $this->config->getUserValue($user->getUid(), Application::APP_ID, 'enabled', '1'),
+            'top-menu-apps' => (array) json_decode($this->config->getUserValue($user->getUid(), Application::APP_ID, 'top-menu-apps', '[]'), true),
+            'target-blank-mode' => $this->config->getUserValue($user->getUid(), Application::APP_ID, 'target-blank-mode', '1'),
+            'target-blank-apps' => (array) json_decode($this->config->getUserValue($user->getUid(), Application::APP_ID, 'target-blank-apps', '[]'), true),
             'apps' => $this->appRepository->getVisibleApps(),
         ];
 
-        return new TemplateResponse('side_menu', 'settings/personal-form', $parameters, '');
+        return new TemplateResponse(Application::APP_ID, 'settings/personal-form', $parameters, '');
     }
 
     /**
@@ -85,7 +86,7 @@ class Personal implements ISettings
      */
     public function getSection()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**

lib/Settings/PersonalSection.php

@@ -21,6 +21,7 @@ namespace OCA\SideMenu\Settings;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 use OCP\Settings\IIconSection;
+use OCA\SideMenu\AppInfo\Application;
 
 class PersonalSection implements IIconSection
 {
@@ -52,7 +53,7 @@ class PersonalSection implements IIconSection
      */
     public function getID()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**
@@ -63,7 +64,7 @@ class PersonalSection implements IIconSection
      */
     public function getName()
     {
-        return $this->l->t('Side menu');
+        return $this->l->t(Application::APP_NAME);
     }
 
     /**

src/SideMenu.vue

@@ -19,9 +19,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
         <div class="side-menu-header">
             <button class="side-menu-opener"></button>
 
-            <div v-if="logo" v-bind:class="{'side-menu-logo': true, 'avatardiv': isAvatar}">
+            <div v-if="!avatar && logo" v-bind:class="{'side-menu-logo': true, 'avatardiv': false}">
                 <img v-bind:src="logo">
             </div>
+            <div v-if="avatar" v-bind:class="{'side-menu-logo': true, 'avatardiv': true}">
+                <img v-bind:src="avatar">
+            </div>
         </div>
 
         <ul class="side-menu-apps-list">
@@ -37,6 +40,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 
 <script>
 import trim from 'trim'
+import axios from 'axios'
 
 export default {
     name: 'SideMenu',
@@ -44,9 +48,9 @@ export default {
         return {
             apps: [],
             logo: null,
+            avatar: null,
             forceLightIcon: false,
-			targetBlank: false,
-			isAvatar: false,
+            targetBlankApps: [],
         }
     },
     methods: {
@@ -88,7 +92,7 @@ export default {
                     }
 
                     this.apps.push({
-						id: dataId,
+                        id: dataId,
                         href: href,
                         name: trim(element.querySelector('span').innerHTML),
                         icon: svg,
@@ -103,30 +107,25 @@ export default {
                 }, 1000)
             })(this.apps)
         },
-        retrieveLogo() {
-            const ncLogo = document.querySelector('#nextcloud .logo')
-			const avatar = document.querySelector('#side-menu-container').getAttribute('data-avatar');
 
-			if (avatar) {
-				this.logo = avatar
-				this.isAvatar = true
-			} else if (ncLogo) {
-                const url = window.getComputedStyle(ncLogo, null)
-                    .getPropertyValue('background-image')
-                    .replace('url("', '')
-                    .replace('")', '')
+        retrieveConfig() {
+            let that = this
 
-                if (url && url !== 'none') {
-                    this.logo = url
-                }
-            }
+            axios
+                .get(OC.generateUrl('/apps/side_menu/js/config'))
+                .then(function(response) {
+                    const config = response.data
+
+                    that.targetBlankApps = config['target-blank-apps']
+                    that.forceLightIcon = config['force-light-icon']
+                    that.avatar = config['avatar']
+                    that.logo = config['logo']
+                });
         },
     },
     mounted() {
+        this.retrieveConfig()
         this.retrieveApps()
-        this.retrieveLogo()
-        this.forceLightIcon = document.querySelector('#side-menu-container').getAttribute('data-forcelighticon') == 1;
-        this.targetBlankApps = document.querySelector('#side-menu-container').getAttribute('data-targetblankapps').split(',');
 
         const menu = document.querySelector('#appmenu')
 

src/SideMenuBig.vue

@@ -18,7 +18,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
     <div id="side-menu" class="side-menu-big">
         <div class="side-menu-header">
             <button class="side-menu-opener side-menu-closer"></button>
-			<button class="side-menu-opener"></button>
+            <button class="side-menu-opener"></button>
         </div>
 
         <div class="side-menu-categories-wrapper">
@@ -50,7 +50,8 @@ export default {
         return {
             items: [],
             activeApp: null,
-			targetBlank: false,
+            targetBlank: false,
+            targetBlankApps: [],
         }
     },
     methods: {
@@ -74,14 +75,26 @@ export default {
                     jQuery('body').trigger('side-menu.apps', [apps])
                 });
         },
+
         retrieveActiveApp() {
             let activeAppLink = document.querySelector('#appmenu a.active')
             this.activeApp = activeAppLink ? activeAppLink.parentNode.getAttribute('data-id') : null
         },
+
+        retrieveConfig() {
+            let that = this
+
+            axios
+                .get(OC.generateUrl('/apps/side_menu/js/config'))
+                .then(function(response) {
+                    const config = response.data
+
+                    that.targetBlankApps = config['target-blank-apps']
+                });
+        },
     },
     mounted() {
-        this.targetBlankApps = document.querySelector('#side-menu-container').getAttribute('data-targetblankapps').split(',');
-
+        this.retrieveConfig()
         this.retrieveApps()
         this.retrieveActiveApp()
     }

src/l10n/fixtures/de.yaml

@@ -56,3 +56,4 @@
 "Use the global setting": "Verwende die globale Einstellung"
 "Use my selection": "Verwende meine Auswahl"
 "Show and hide the list of applications": "Ein- und Ausblenden der Anwendungsliste"
+"Use the avatar instead of the logo": "Verwenden Sie den Avatar anstelle des Logos"

src/l10n/fixtures/fr.yaml

@@ -56,3 +56,4 @@
 "Use the global setting": "Utiliser la configuration globale"
 "Use my selection": "Utiliser ma sélection"
 "Show and hide the list of applications": "Afficher et masquer la liste des applications"
+"Use the avatar instead of the logo": "Utiliser l'avatar à la place du logo"

templates/js/script.php

@@ -10,16 +10,6 @@
         sideMenu.attr('data-bigmenu', '1')
     <?php endif; ?>
 
-    <?php if ($_['force-light-icon']): ?>
-        sideMenuContainer.attr('data-forcelighticon', '1')
-    <?php endif; ?>
-    
-    <?php if ($_['avatar']): ?>
-        sideMenuContainer.attr('data-avatar', '<?php p($avatar) ?>')
-    <?php endif; ?>
-
-    sideMenuContainer.attr('data-targetblankapps', '<?php p(implode(',', $_['target-blank-apps'])) ?>')
-
     var targetBlankApps = <?php echo json_encode($_['target-blank-apps']) ?>;
 
     body.on('side-menu.apps', function(e, apps) {