change typo

- add a controller to retrieve most of the configuration

ISSUE_TEMPLATE.md

@@ -15,8 +15,10 @@
 ### Environment
 
 * Side menu version: ...
+* Nextcloud version: ...
 * PHP version: ...
 * Web server (Nginx, Apache2): ...
+* Web browser and version (Firefox 80, Google Chrome 74, etc): ...
 
 ### Steps to reproduce
 

README.md

@@ -1,7 +1,7 @@
-🤙 Nextcloud app / Side menu 🎨
+🤙 Nextcloud app / Custom menu 🎨
 ===============================
 
-Side menu allows you to modify the position of the main menu by creating a panel on the left of the interface or with a big menu on the top.
+Allows you to modify the position of the main menu by creating a panel on the left of the interface or with a big menu on the top.
 You can also define apps that must be displayed in the top menu. Fully customisable.
 
 This application is rather suitable for instances that activate a lot of applications.
@@ -17,7 +17,7 @@ You like this app and you want to support me? [Buy me a coffee](https://www.buym
 Installation and upgrade
 ------------------------
 
-Side menu is availabe from the app store. If you want to install it from source: go to https://gitnet.fr/deblan/side_menu/releases and download the last release (side_menu_vX.Y.Z.zip). Copy the content into `apps`.
+Custom menu is available from the app store. If you want to install it from source: go to https://gitnet.fr/deblan/side_menu/releases and download the last release (side_menu_vX.Y.Z.zip). Copy the content into `apps`.
 
 ```
 $ cd /path/to/nextcloud/apps

appinfo/info.xml

@@ -1,9 +1,10 @@
 <?xml version="1.0"?>
-<info>
+<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
+      xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
     <id>side_menu</id>
-    <name>Side menu</name>
+    <name>Custom menu</name>
     <summary>Modify the display of the menu.</summary>
-    <description><![CDATA[Side menu allows you to modify the position of the main menu by creating a panel on the left of the interface or with a big menu on the top.
+    <description><![CDATA[Custom menu allows you to modify the position of the main menu by creating a panel on the left of the interface or with a big menu on the top.
 You can also define apps that must be displayed in the top menu. Fully customisable.
 
 This application is rather suitable for instances that activate a lot of applications.
@@ -14,20 +15,22 @@ Comptatible with AppOrder.
 
 You can report a bug or request a feature by opening an issue.
 
-If you like this app, leave a review on https://apps.nextcloud.com/apps/side_menu
-
-You like this app and you want to support me?
+If you like this application and want to support the development:
 
 * ☕ [Buy me a coffee](https://www.buymeacoffee.com/deblan)
 * 😃 [Leave a comment](https://apps.nextcloud.com/apps/side_menu#comments)
 ]]></description>
+    <version>1.17.0</version>
     <licence>agpl</licence>
     <author mail="contact@deblan.fr" homepage="https://www.deblan.io/">Simon Vieille</author>
-    <version>1.13.0</version>
     <namespace>SideMenu</namespace>
+    <documentation>
+        <admin>https://gitnet.fr/deblan/side_menu/src/branch/master/README.md</admin>
+        <developer>https://gitnet.fr/deblan/side_menu/src/branch/master/README.md</developer>
+    </documentation>
     <category>customization</category>
     <website>https://gitnet.fr/deblan/side_menu</website>
-    <discussion>https://deblan.cloud/index.php/call/fffxkc7h</discussion>
+    <discussion>https://matrix.to/#/!GhfQePnOSPYpYEunWM:neutralnetwork.org</discussion>
     <bugs>https://gitnet.fr/deblan/side_menu/issues</bugs>
     <repository type="git">https://gitnet.fr/deblan/side_menu</repository>
     <screenshot>https://gitnet.fr/deblan/side_menu/raw/branch/master/screenshots/nc19_default_menu.png</screenshot>
@@ -36,10 +39,6 @@ You like this app and you want to support me?
     <screenshot>https://gitnet.fr/deblan/side_menu/raw/branch/master/screenshots/nc18_menu_always_displayed.png</screenshot>
     <screenshot>https://gitnet.fr/deblan/side_menu/raw/branch/master/screenshots/nc20_big_menu_responsive.png</screenshot>
     <screenshot>https://gitnet.fr/deblan/side_menu/raw/branch/master/screenshots/personal_settings.png</screenshot>
-    <documentation>
-        <admin>https://gitnet.fr/deblan/side_menu/src/branch/master/README.md</admin>
-        <developer>https://gitnet.fr/deblan/side_menu/src/branch/master/README.md</developer>
-    </documentation>
     <dependencies>
         <nextcloud min-version="18" max-version="20"/>
     </dependencies>

appinfo/routes.php

@@ -19,9 +19,12 @@
 
 return [
     'routes' => [
-		['name' => 'Css#stylesheet', 'url' => '/css/stylesheet', 'verb' => 'GET'],
-		['name' => 'Js#script', 'url' => '/js/script', 'verb' => 'GET'],
-		['name' => 'Nav#items', 'url' => '/nav/items', 'verb' => 'GET'],
-		['name' => 'PersonalSetting#valueSet', 'url' => '/personalSetting/valueSet', 'verb' => 'POST'],
+        ['name' => 'Css#stylesheet', 'url' => '/css/stylesheet', 'verb' => 'GET'],
+        ['name' => 'Js#script', 'url' => '/js/script', 'verb' => 'GET'],
+        ['name' => 'Js#config', 'url' => '/js/config', 'verb' => 'GET'],
+        ['name' => 'Nav#items', 'url' => '/nav/items', 'verb' => 'GET'],
+        ['name' => 'PersonalSetting#valueSet', 'url' => '/personalSetting/valueSet', 'verb' => 'POST'],
+        ['name' => 'AdminSetting#removeCache', 'url' => '/admin/cache/remove', 'verb' => 'GET'],
+        ['name' => 'AdminSetting#exportConfiguration', 'url' => '/admin/config/export', 'verb' => 'GET'],
     ],
 ];

css/sideMenu.css

@@ -175,6 +175,16 @@
     color: var(--side-menu-text-color, #fff);
 }
 
+.side-menu-loader {
+    text-align: center;
+}
+
+.side-menu-loader svg {
+    width: 38px;
+    margin: auto;
+    stroke: var(--side-menu-text-color, #fff);
+}
+
 .side-menu-big .side-menu-app-icon {
     vertical-align: middle;
     margin-top: -2px;

img/icon.svg

@@ -0,0 +1,113 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!-- Created with Inkscape (http://www.inkscape.org/) -->
+
+<svg
+   xmlns:dc="http://purl.org/dc/elements/1.1/"
+   xmlns:cc="http://creativecommons.org/ns#"
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+   xmlns:svg="http://www.w3.org/2000/svg"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   width="37.099998mm"
+   height="37.099998mm"
+   viewBox="0 0 37.099998 37.099998"
+   version="1.1"
+   id="svg8"
+   inkscape:version="0.92.4 (5da689c313, 2019-01-14)"
+   sodipodi:docname="icon.svg">
+  <defs
+     id="defs2" />
+  <sodipodi:namedview
+     id="base"
+     pagecolor="#ffffff"
+     bordercolor="#666666"
+     borderopacity="1.0"
+     inkscape:pageopacity="0.0"
+     inkscape:pageshadow="2"
+     inkscape:zoom="2.8"
+     inkscape:cx="242.1839"
+     inkscape:cy="32.026866"
+     inkscape:document-units="mm"
+     inkscape:current-layer="layer1"
+     showgrid="false"
+     fit-margin-top="0"
+     fit-margin-left="0"
+     fit-margin-right="0"
+     fit-margin-bottom="0"
+     inkscape:window-width="1918"
+     inkscape:window-height="1027"
+     inkscape:window-x="1920"
+     inkscape:window-y="21"
+     inkscape:window-maximized="0"
+     inkscape:snap-nodes="false" />
+  <metadata
+     id="metadata5">
+    <rdf:RDF>
+      <cc:Work
+         rdf:about="">
+        <dc:format>image/svg+xml</dc:format>
+        <dc:type
+           rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
+        <dc:title></dc:title>
+      </cc:Work>
+    </rdf:RDF>
+  </metadata>
+  <g
+     inkscape:label="Calque 1"
+     inkscape:groupmode="layer"
+     id="layer1"
+     transform="translate(-59.922223,-92.669069)">
+    <rect
+       style="color:#000000;display:inline;overflow:visible;visibility:visible;opacity:1;vector-effect:none;fill:#ffffff;fill-opacity:1;fill-rule:nonzero;stroke:#1a1a1a;stroke-width:1.46500015;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;paint-order:fill markers stroke;enable-background:accumulate"
+       id="rect815-6-2-7"
+       width="34.535"
+       height="34.535"
+       x="61.204723"
+       y="93.951569"
+       rx="5.4806547"
+       ry="5.4806547" />
+    <rect
+       style="color:#000000;display:inline;overflow:visible;visibility:visible;opacity:1;vector-effect:none;fill:#ececec;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1.46500015;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;paint-order:fill markers stroke;enable-background:accumulate"
+       id="rect815-6-7"
+       width="20.357224"
+       height="33.40107"
+       x="61.677193"
+       y="94.518532"
+       rx="0"
+       ry="0" />
+    <path
+       style="fill:none;fill-rule:evenodd;stroke:#333333;stroke-width:3.16499996;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+       d="m 66.59458,111.16177 h 9.997359"
+       id="path873-5"
+       inkscape:connector-curvature="0" />
+    <g
+       id="g1018"
+       transform="translate(2.6458333)"
+       style="stroke:#333333;stroke-opacity:1">
+      <g
+         id="g1013"
+         style="stroke:#333333;stroke-opacity:1">
+        <path
+           style="fill:none;fill-rule:evenodd;stroke:#333333;stroke-width:3.16499996;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+           d="M 63.948747,103.80467 H 75.349244"
+           id="path873"
+           inkscape:connector-curvature="0" />
+        <path
+           style="fill:none;fill-rule:evenodd;stroke:#333333;stroke-width:3.16499996;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
+           d="M 63.948747,118.51887 H 75.349244"
+           id="path873-5-3"
+           inkscape:connector-curvature="0" />
+      </g>
+    </g>
+    <rect
+       style="color:#000000;display:inline;overflow:visible;visibility:visible;opacity:1;vector-effect:none;fill:none;fill-opacity:1;fill-rule:nonzero;stroke:#333333;stroke-width:2.56500006;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;paint-order:fill markers stroke;enable-background:accumulate"
+       id="rect815-6-2"
+       width="34.535"
+       height="34.535"
+       x="61.204723"
+       y="93.951569"
+       rx="5.4806547"
+       ry="5.4806547" />
+  </g>
+</svg>

img/loader.svg

@@ -0,0 +1,17 @@
+<!-- By Sam Herbert (@sherb), for everyone. More @ http://goo.gl/7AJzbL -->
+<svg width="38" height="38" viewBox="0 0 38 38" xmlns="http://www.w3.org/2000/svg" stroke="#fff">
+    <g fill="none" fill-rule="evenodd">
+        <g transform="translate(1 1)" stroke-width="2">
+            <circle stroke-opacity=".5" cx="18" cy="18" r="18"/>
+            <path d="M36 18c0-9.94-8.06-18-18-18">
+                <animateTransform
+                    attributeName="transform"
+                    type="rotate"
+                    from="0 18 18"
+                    to="360 18 18"
+                    dur="1s"
+                    repeatCount="indefinite"/>
+            </path>
+        </g>
+    </g>
+</svg>

lib/AppInfo/Application.php

@@ -6,6 +6,7 @@ use OC;
 use OC\Security\CSP\ContentSecurityPolicyNonceManager;
 use OC\User\User;
 use OCA\SideMenu\Service\AppRepository;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\App;
 use OCP\IUserSession;
 use OCP\Util;
@@ -18,6 +19,9 @@ use Psr\Container\ContainerInterface;
  */
 class Application extends App
 {
+    public const APP_ID = 'side_menu';
+
+    public const APP_NAME = 'Custom menu';
     /**
      * @var OC\AllConfig
      */
@@ -38,7 +42,7 @@ class Application extends App
      */
     public function __construct(array $urlParams = [])
     {
-        parent::__construct('side_menu', $urlParams);
+        parent::__construct(self::APP_ID, $urlParams);
 
         $this->config = OC::$server->getConfig();
         $this->cspnm = OC::$server->getContentSecurityPolicyNonceManager();
@@ -51,9 +55,10 @@ class Application extends App
     public function isEnabled(): bool
     {
         $enabled = true;
+        $isForced = (bool) $this->config->getAppValue(self::APP_ID, 'force', '0');
 
-        if (null !== $this->user) {
-            $enabled = (bool) $this->config->getUserValue($this->user->getUid(), 'side_menu', 'enabled', '1');
+        if (null !== $this->user && !$isForced) {
+            $enabled = (bool) $this->config->getUserValue($this->user->getUid(), self::APP_ID, 'enabled', '1');
         }
 
         return $enabled;
@@ -67,7 +72,11 @@ class Application extends App
         $container = $this->getContainer();
 
         $container->registerService('AppRepository', function (ContainerInterface $c) {
-            return new AppRepository(new OC_App());
+            return new AppRepository();
+        });
+
+        $container->registerService('ConfigProxy', function (ContainerInterface $c) {
+            return new ConfigProxy($this->config);
         });
     }
 
@@ -76,20 +85,20 @@ class Application extends App
      */
     public function registerAssets()
     {
-        Util::addScript('side_menu', 'sideMenu');
-        Util::addStyle('side_menu', 'sideMenu');
+        Util::addScript(self::APP_ID, 'sideMenu');
+        Util::addStyle(self::APP_ID, 'sideMenu');
 
         $stylesheet = OC::$server->getURLGenerator()->linkToRoute(
             'side_menu.Css.stylesheet',
             [
-                'v' => $this->config->getAppValue('side_menu', 'cache', '0'),
+                'v' => $this->config->getAppValue(self::APP_ID, 'cache', '0'),
             ]
         );
 
         $script = OC::$server->getURLGenerator()->linkToRoute(
             'side_menu.Js.script',
             [
-                'v' => $this->config->getAppValue('side_menu', 'cache', '0'),
+                'v' => $this->config->getAppValue(self::APP_ID, 'cache', '0'),
             ]
         );
 

lib/Controller/AdminSettingController.php

@@ -0,0 +1,92 @@
+<?php
+/**
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+namespace OCA\SideMenu\Controller;
+
+use OCA\SideMenu\AppInfo\Application;
+use OCP\AppFramework\Controller;
+use OCP\AppFramework\Http\DataDownloadResponse;
+use OCP\AppFramework\Http\RedirectResponse;
+use OCP\AppFramework\Http\Response;
+use OCP\IConfig;
+use OCP\IRequest;
+use OCP\IURLGenerator;
+
+class AdminSettingController extends Controller
+{
+    /**
+     * @var IConfig
+     */
+    protected $config;
+
+    /**
+     * @var IURLGenerator
+     */
+    protected $urlGenerator;
+
+    public function __construct($appName, IRequest $request, IConfig $config, IURLGenerator $urlGenerator)
+    {
+        parent::__construct($appName, $request);
+
+        $this->config = $config;
+        $this->urlGenerator = $urlGenerator;
+    }
+
+    /**
+     * @NoCSRFRequired
+     *
+     * @return RedirectResponse
+     */
+    public function removeCache()
+    {
+        $this->config->setAppValue(Application::APP_ID, 'cache-categories', '[]');
+
+        return new RedirectResponse($this->urlGenerator->linkToRoute('settings.AdminSettings.index', [
+            'section' => Application::APP_ID,
+        ]).'#more');
+    }
+
+    /**
+     * @NoCSRFRequired
+     *
+     * @return Response
+     */
+    public function exportConfiguration()
+    {
+        $keys = $this->config->getAppKeys(Application::APP_ID);
+        $config = [];
+        $excludedKeys = [
+            'cache',
+            'cache-categories',
+        ];
+
+        foreach ($keys as $key) {
+            if (in_array($key, $excludedKeys)) {
+                continue;
+            }
+
+            $config[$key] = $this->config->getAppValue(Application::APP_ID, $key);
+        }
+
+        return new DataDownloadResponse(
+            json_encode($config, JSON_PRETTY_PRINT),
+            'config.json',
+            'text/json'
+        );
+    }
+}

lib/Controller/CssController.php

@@ -19,27 +19,32 @@
 namespace OCA\SideMenu\Controller;
 
 use OC;
+use OC\User\User;
+use OCA\SideMenu\AppInfo\Application;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\Response;
 use OCP\AppFramework\Http\TemplateResponse;
-use OCP\IConfig;
 use OCP\IRequest;
 use OCP\IUserSession;
 
 class CssController extends Controller
 {
     /**
-     * @var \OCP\IConfig
+     * @var ConfigProxy
      */
     protected $config;
 
     /**
-     * @param string $appName
+     * @var User
      */
-    public function __construct($appName, IRequest $request, IConfig $config)
+    protected $user;
+
+    public function __construct(string $appName, IRequest $request, ConfigProxy $config)
     {
         parent::__construct($appName, $request);
 
+        $this->user = OC::$server[IUserSession::class]->getUser();
         $this->config = $config;
     }
 
@@ -52,44 +57,46 @@ class CssController extends Controller
      */
     public function stylesheet()
     {
-        $backgroundColor = $this->config->getAppValue('side_menu', 'background-color', '#333333');
-        $backgroundColorTo = $this->config->getAppValue('side_menu', 'background-color-to', $backgroundColor);
-
-        $user = OC::$server[IUserSession::class]->getUser();
-        $topMenuApps = (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true);
-
-        if ($user) {
-            $userTopMenuApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true);
-
-            if (!empty($userTopMenuApps)) {
-                $topMenuApps = $userTopMenuApps;
-            }
-        }
-
-        $parameters = [
-            'vars' => [
-                'background-color' => $backgroundColor,
-                'background-color-to' => $backgroundColorTo,
-                'current-app-background-color' => $this->config->getAppValue('side_menu', 'current-app-background-color', '#444444'),
-                'loader-color' => $this->config->getAppValue('side_menu', 'loader-color', '#0e75ac'),
-                'text-color' => $this->config->getAppValue('side_menu', 'text-color', '#FFFFFF'),
-                'opener' => $this->config->getAppValue('side_menu', 'opener', 'side-menu-opener'),
-                'icon-invert-filter' => abs((int) $this->config->getAppValue('side_menu', 'icon-invert-filter', '0')).'%',
-                'icon-opacity' => abs((int) $this->config->getAppValue('side_menu', 'icon-opacity', '100') / 100),
-            ],
-            'display-logo' => (bool) $this->config->getAppValue('side_menu', 'display-logo', 1),
-            'opener-only' => (bool) $this->config->getAppValue('side_menu', 'opener-only', 0),
-            'external-sites-in-top-menu' => (bool) $this->config->getAppValue('side_menu', 'external-sites-in-top-menu', 0),
-            'size-icon' => $this->config->getAppValue('side_menu', 'size-icon', 'normal'),
-            'size-text' => $this->config->getAppValue('side_menu', 'size-text', 'normal'),
-            'always-displayed' => (bool) $this->config->getAppValue('side_menu', 'always-displayed', '0'),
-            'big-menu' => (bool) $this->config->getAppValue('side_menu', 'big-menu', '0'),
-            'top-menu-apps' => $topMenuApps,
-        ];
-
-        $response = new TemplateResponse('side_menu', 'css/stylesheet', $parameters, 'blank');
+        $response = new TemplateResponse(Application::APP_ID, 'css/stylesheet', $this->getConfig(), 'blank');
         $response->addHeader('Content-Type', 'text/css');
 
         return $response;
     }
+
+    protected function getConfig(): array
+    {
+        $backgroundColor = $this->config->getAppValue('background-color', '#333333');
+        $backgroundColorTo = $this->config->getAppValue('background-color-to', $backgroundColor);
+        $isForced = $this->config->getAppValueBool('force', '0');
+        $topMenuApps = $this->config->getAppValueArray('top-menu-apps', '[]');
+
+        if ($this->user) {
+            $userTopMenuApps = $this->config->getUserValueArray($this->user, 'top-menu-apps', '[]');
+
+            if (!empty($userTopMenuApps) && !$isForced) {
+                $topMenuApps = $userTopMenuApps;
+            }
+        }
+
+        return [
+            'vars' => [
+                'background-color' => $backgroundColor,
+                'background-color-to' => $backgroundColorTo,
+                'current-app-background-color' => $this->config->getAppValue('current-app-background-color', '#444444'),
+                'loader-color' => $this->config->getAppValue('loader-color', '#0e75ac'),
+                'text-color' => $this->config->getAppValue('text-color', '#FFFFFF'),
+                'opener' => $this->config->getAppValue('opener', 'side-menu-opener'),
+                'icon-invert-filter' => abs($this->config->getAppValueInt('icon-invert-filter', '0')).'%',
+                'icon-opacity' => abs($this->config->getAppValueInt('icon-opacity', '100') / 100),
+            ],
+            'display-logo' => $this->config->getAppValueBool('display-logo', '1'),
+            'opener-only' => $this->config->getAppValueBool('opener-only', '0'),
+            'external-sites-in-top-menu' => $this->config->getAppValueBool('external-sites-in-top-menu', '0'),
+            'size-icon' => $this->config->getAppValue('size-icon', 'normal'),
+            'size-text' => $this->config->getAppValue('size-text', 'normal'),
+            'always-displayed' => $this->config->getAppValueBool('always-displayed', '0'),
+            'big-menu' => $this->config->getAppValueBool('big-menu', '0'),
+            'top-menu-apps' => $topMenuApps,
+        ];
+    }
 }

lib/Controller/JsController.php

@@ -19,27 +19,40 @@
 namespace OCA\SideMenu\Controller;
 
 use OC;
+use OC\User\User;
+use OCA\SideMenu\AppInfo\Application;
+use OCA\SideMenu\Service\ConfigProxy;
+use OCA\Theming\ThemingDefaults;
 use OCP\AppFramework\Controller;
-use OCP\AppFramework\Http\Response;
+use OCP\AppFramework\Http\JSONResponse;
 use OCP\AppFramework\Http\TemplateResponse;
-use OCP\IConfig;
 use OCP\IRequest;
 use OCP\IUserSession;
 
 class JsController extends Controller
 {
     /**
-     * @var \OCP\IConfig
+     * @var ConfigProxy
      */
     protected $config;
 
     /**
-     * @param string $appName
+     * @var User
      */
-    public function __construct($appName, IRequest $request, IConfig $config)
+    protected $user;
+
+    /**
+     * @var ThemingDefaults
+     */
+    protected $themingDefaults;
+
+    public function __construct(string $appName, IRequest $request, ConfigProxy $config, ThemingDefaults $themingDefaults)
     {
         parent::__construct($appName, $request);
 
+        $this->themingDefaults = $themingDefaults;
+
+        $this->user = OC::$server[IUserSession::class]->getUser();
         $this->config = $config;
     }
 
@@ -47,61 +60,73 @@ class JsController extends Controller
      * @NoAdminRequired
      * @NoCSRFRequired
      * @PublicPage
-     *
-     * @return Response
      */
-    public function script()
+    public function script(): TemplateResponse
     {
-        $user = OC::$server[IUserSession::class]->getUser();
-        $topMenuApps = (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true);
-        $targetBlankApps = (array) json_decode($this->config->getAppValue('side_menu', 'target-blank-apps', '[]'), true);
-        $useAvatar = (bool) $this->config->getAppValue('side_menu', 'use-avatar', '0');
+        $response = new TemplateResponse(Application::APP_ID, 'js/script', $this->getConfig(), 'blank');
+        $response->addHeader('Content-Type', 'text/javascript');
+
+        return $response;
+    }
+
+    /**
+     * @NoAdminRequired
+     * @NoCSRFRequired
+     * @PublicPage
+     */
+    public function config(): JSONResponse
+    {
+        return new JSONResponse($this->getConfig());
+    }
+
+    protected function getConfig(): array
+    {
+        $topMenuApps = $this->config->getAppValueArray('top-menu-apps', '[]');
+        $targetBlankApps = $this->config->getAppValueArray('target-blank-apps', '[]');
+        $useAvatar = $this->config->getAppValueBool('use-avatar', '0');
+        $isForced = $this->config->getAppValueBool('force', '0');
         $avatar = null;
 
-        if ($user) {
-            $userTopMenuApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true);
+        if ($this->user) {
+            $userTopMenuApps = $this->config->getUserValueArray($this->user, 'top-menu-apps', '[]');
 
-            if (!empty($userTopMenuApps)) {
+            if (!empty($userTopMenuApps) && !$isForced) {
                 $topMenuApps = $userTopMenuApps;
             }
 
-            $userTargetBlankMode = (int) $this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-mode', '1');
-            $userTargetBlankApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-apps', '[]'), true);
+            $userTargetBlankMode = $this->config->getUserValueInt($this->user, 'target-blank-mode', '1');
+            $userTargetBlankApps = $this->config->getUserValueArray($this->user, 'target-blank-apps', '[]');
 
-            if (2 === $userTargetBlankMode) {
+            if (2 === $userTargetBlankMode && !$isForced) {
                 $targetBlankApps = $userTargetBlankApps;
             }
 
-            $isAvatarSet = OC::$server->getAvatarManager()->getAvatar($user->getUid())->exists();
+            $isAvatarSet = OC::$server->getAvatarManager()->getAvatar($this->user->getUid())->exists();
 
             if ($useAvatar && $isAvatarSet) {
                 $avatar = OC::$server->getURLGenerator()->linkToRoute(
                     'core.avatar.getAvatar', [
-                        'userId' => $user->getUid(),
+                        'userId' => $this->user->getUid(),
                         'size' => 128,
-                        'v' => $this->config->getUserValue($user, 'avatar', 'version', 0),
+                        'v' => $this->config->getUserValueInt($this->user, 'avatar', 'version', 0),
                     ]
                 );
             }
         }
 
-        $parameters = [
-            'opener-position' => $this->config->getAppValue('side_menu', 'opener-position', 'before'),
-            'opener-hover' => (bool) $this->config->getAppValue('side_menu', 'opener-hover', '0'),
-            'external-sites-in-top-menu' => (bool) $this->config->getAppValue('side_menu', 'external-sites-in-top-menu', 0),
-            'force-light-icon' => (bool) $this->config->getAppValue('side_menu', 'force-light-icon', '0'),
-            'hide-when-no-apps' => (bool) $this->config->getAppValue('side_menu', 'hide-when-no-apps', '0'),
-            'loader-enabled' => (bool) $this->config->getAppValue('side_menu', 'loader-enabled', '1'),
-            'always-displayed' => (bool) $this->config->getAppValue('side_menu', 'always-displayed', '0'),
-            'big-menu' => (bool) $this->config->getAppValue('side_menu', 'big-menu', '0'),
+        return [
+            'opener-position' => $this->config->getAppValue('opener-position', 'before'),
+            'opener-hover' => $this->config->getAppValueBool('opener-hover', '0'),
+            'external-sites-in-top-menu' => $this->config->getAppValueBool('external-sites-in-top-menu', '0'),
+            'force-light-icon' => $this->config->getAppValueBool('force-light-icon', '0'),
+            'hide-when-no-apps' => $this->config->getAppValueBool('hide-when-no-apps', '0'),
+            'loader-enabled' => $this->config->getAppValueBool('loader-enabled', '1'),
+            'always-displayed' => $this->config->getAppValueBool('always-displayed', '0'),
+            'big-menu' => $this->config->getAppValueBool('big-menu', '0'),
             'avatar' => $avatar,
             'top-menu-apps' => $topMenuApps,
             'target-blank-apps' => $targetBlankApps,
+            'logo' => $this->themingDefaults->getLogo(),
         ];
-
-        $response = new TemplateResponse('side_menu', 'js/script', $parameters, 'blank');
-        $response->addHeader('Content-Type', 'text/javascript');
-
-        return $response;
     }
 }

lib/Controller/NavController.php

@@ -21,7 +21,9 @@ namespace OCA\SideMenu\Controller;
 use OC;
 use OC\App\AppStore\Fetcher\CategoryFetcher;
 use OC\URLGenerator;
+use OCA\SideMenu\AppInfo\Application;
 use OCA\SideMenu\Service\AppRepository;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\IConfig;
@@ -33,10 +35,15 @@ use OCP\L10N\IFactory;
 class NavController extends Controller
 {
     /**
-     * @var IConfig
+     * @var ConfigProxy
      */
     protected $config;
 
+    /**
+     * @var IConfig
+     */
+    protected $iConfig;
+
     /**
      * @var AppRepository
      */
@@ -57,13 +64,11 @@ class NavController extends Controller
      */
     protected $router;
 
-    /**
-     * @param string $appName
-     */
     public function __construct(
-        $appName,
+        string $appName,
         IRequest $request,
-        IConfig $config,
+        IConfig $iConfig,
+        ConfigProxy $config,
         AppRepository $appRepository,
         CategoryFetcher $categoryFetcher,
         URLGenerator $router,
@@ -73,6 +78,7 @@ class NavController extends Controller
         parent::__construct($appName, $request);
 
         $this->config = $config;
+        $this->iConfig = $iConfig;
         $this->appRepository = $appRepository;
         $this->categoryFetcher = $categoryFetcher;
         $this->l10nFactory = $l10nFactory;
@@ -90,9 +96,9 @@ class NavController extends Controller
     {
         $apps = $this->appRepository->getVisibleApps();
         $currentLanguage = substr($this->l10nFactory->findLanguage(), 0, 2);
-        $categoriesLabels = $this->categoryFetcher->get();
-        $externalSitesInTopMenu = (bool) $this->config->getAppValue('side_menu', 'external-sites-in-top-menu', 0);
+        $externalSitesInTopMenu = $this->config->getAppValueBool('external-sites-in-top-menu', '0');
         $user = OC::$server[IUserSession::class]->getUser();
+        $isForced = $this->config->getAppValueBool('force', '0');
         $appsCategories = [];
         $categoriesAppsCount = [];
         $items = [];
@@ -103,10 +109,18 @@ class NavController extends Controller
             ]);
         }
 
-        $topMenuApps = (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true);
-        $userTopMenuApps = (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true);
+        $categoriesLabels = $this->config->getAppValueArray('cache-categories', '[]');
 
-        if (!empty($userTopMenuApps)) {
+        if (empty($categoriesLabels)) {
+            $categoriesLabels = $this->categoryFetcher->get();
+
+            $this->iConfig->setAppValue(Application::APP_ID, 'cache-categories', json_encode($categoriesLabels));
+        }
+
+        $topMenuApps = $this->config->getAppValueArray('top-menu-apps', '[]');
+        $userTopMenuApps = $this->config->getUserValueArray($user, 'top-menu-apps', '[]');
+
+        if (!$isForced && !empty($userTopMenuApps)) {
             $topMenuApps = $userTopMenuApps;
         }
 
@@ -138,7 +152,7 @@ class NavController extends Controller
             foreach ($categories as $category) {
                 if (!isset($items[$category])) {
                     $items[$category] = [
-                        'name' => $categoriesLabels[$category],
+                        'name' => $categoriesLabels[$category] ?? $category,
                         'apps' => [],
                     ];
                 }

lib/Controller/PersonalSettingController.php

@@ -23,24 +23,32 @@ use OCP\AppFramework\Http\Response;
 use OCP\IConfig;
 use OCP\IRequest;
 use OCP\IUserSession;
+use OCA\SideMenu\AppInfo\Application;
+use OCA\SideMenu\Service\ConfigProxy;
 
 class PersonalSettingController extends Controller
 {
     /**
-     * @var \OCP\IConfig
+     * @var IConfig
      */
     protected $config;
 
+    /**
+     * @var ConfigProxy
+     */
+    protected $configProxy;
+
     /**
      * @var IUserSession
      */
-    private $userSession;
+    protected $userSession;
 
-    public function __construct($appName, IRequest $request, IConfig $config, IUserSession $userSession)
+    public function __construct($appName, IRequest $request, IConfig $config, ConfigProxy $configProxy, IUserSession $userSession)
     {
         parent::__construct($appName, $request);
 
         $this->config = $config;
+        $this->configProxy = $configProxy;
         $this->userSession = $userSession;
     }
 
@@ -103,8 +111,12 @@ class PersonalSettingController extends Controller
             }
         }
 
+        if ($this->configProxy->getAppValueBool('force', '0')) {
+            $doSave = false;
+        }
+
         if ($doSave) {
-            $this->config->setUserValue($user->getUid(), 'side_menu', $name, $value);
+            $this->config->setUserValue($user->getUid(), Application::APP_ID, $name, $value);
 
             return [
                 'name' => $name,

lib/Service/AppRepository.php

@@ -2,7 +2,6 @@
 
 namespace OCA\SideMenu\Service;
 
-use OC_App;
 use OCP\L10N\IFactory;
 
 /**
@@ -13,7 +12,7 @@ use OCP\L10N\IFactory;
 class AppRepository
 {
     /**
-     * @var OC_App
+     * @var \OC_App
      */
     protected $ocApp;
 
@@ -22,7 +21,7 @@ class AppRepository
      */
     protected $l10nFactory;
 
-    public function __construct(OC_App $ocApp, IFactory $l10nFactory)
+    public function __construct(\OC_App $ocApp, IFactory $l10nFactory)
     {
         $this->ocApp = $ocApp;
         $this->l10nFactory = $l10nFactory;

lib/Service/ConfigProxy.php

@@ -0,0 +1,65 @@
+<?php
+
+namespace OCA\SideMenu\Service;
+
+use OC\User\User;
+use OCA\SideMenu\AppInfo\Application;
+use OCP\IConfig;
+
+/**
+ * class Config.
+ *
+ * @author Simon Vieille <simon@deblan.fr>
+ */
+class ConfigProxy
+{
+    /**
+     * @var IConfig
+     */
+    protected $config;
+
+    public function __construct(IConfig $config)
+    {
+        $this->config = $config;
+    }
+
+    public function getAppValue(string $name, string $default): string
+    {
+        return (string) $this->config->getAppValue(Application::APP_ID, $name, $default);
+    }
+
+    public function getUserValue(User $user, string $name, string $default): string
+    {
+        return (string) $this->config->getUserValue($user->getUid(), Application::APP_ID, $name, $default);
+    }
+
+    public function getAppValueBool(string $name, string $default): bool
+    {
+        return (bool) $this->getAppValue($name, $default);
+    }
+
+    public function getAppValueArray(string $name, string $default): array
+    {
+        return (array) json_decode($this->getAppValue($name, $default), true);
+    }
+
+    public function getAppValueInt(string $name, string $default): int
+    {
+        return (int) $this->getAppValue($name, $default);
+    }
+
+    public function getUserValueBool(User $user, string $name, string $default): bool
+    {
+        return (bool) $this->getUserValue($user, $name, $default);
+    }
+
+    public function getUserValueArray(User $user, string $name, string $default): array
+    {
+        return (array) json_decode($this->getUserValue($user, $name, $default), true);
+    }
+
+    public function getUserValueInt(User $user, string $name, string $default): int
+    {
+        return (int) $this->getUserValue($user, $name, $default);
+    }
+}

lib/Settings/Admin.php

@@ -18,9 +18,10 @@
 
 namespace OCA\SideMenu\Settings;
 
+use OCA\SideMenu\AppInfo\Application;
 use OCA\SideMenu\Service\AppRepository;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\Http\TemplateResponse;
-use OCP\IConfig;
 use OCP\IL10N;
 use OCP\ILogger;
 use OCP\Settings\ISettings;
@@ -38,7 +39,7 @@ class Admin implements ISettings
     private $logger;
 
     /**
-     * @var IConfig
+     * @var ConfigProxy
      */
     private $config;
 
@@ -47,7 +48,7 @@ class Admin implements ISettings
      */
     private $appRepository;
 
-    public function __construct(IL10N $l, ILogger $logger, IConfig $config, AppRepository $appRepository)
+    public function __construct(IL10N $l, ILogger $logger, ConfigProxy $config, AppRepository $appRepository)
     {
         $this->l = $l;
         $this->logger = $logger;
@@ -60,36 +61,37 @@ class Admin implements ISettings
      */
     public function getForm()
     {
-        $backgroundColor = $this->config->getAppValue('side_menu', 'background-color', '#333333');
-        $backgroundColorTo = $this->config->getAppValue('side_menu', 'background-color-to', $backgroundColor);
+        $backgroundColor = $this->config->getAppValue('background-color', '#333333');
+        $backgroundColorTo = $this->config->getAppValue('background-color-to', $backgroundColor);
 
         $parameters = [
             'background-color' => $backgroundColor,
             'background-color-to' => $backgroundColorTo,
-            'current-app-background-color' => $this->config->getAppValue('side_menu', 'current-app-background-color', '#444444'),
-            'loader-color' => $this->config->getAppValue('side_menu', 'loader-color', '#0e75ac'),
-            'icon-invert-filter' => (int) $this->config->getAppValue('side_menu', 'icon-invert-filter', '0'),
-            'icon-opacity' => (int) $this->config->getAppValue('side_menu', 'icon-opacity', '100'),
-            'loader-enabled' => $this->config->getAppValue('side_menu', 'loader-enabled', '1'),
-            'text-color' => $this->config->getAppValue('side_menu', 'text-color', '#FFFFFF'),
-            'cache' => $this->config->getAppValue('side_menu', 'cache', '0'),
-            'opener' => $this->config->getAppValue('side_menu', 'opener', 'side-menu-opener'),
-            'always-displayed' => $this->config->getAppValue('side_menu', 'always-displayed', '0'),
-            'big-menu' => $this->config->getAppValue('side_menu', 'big-menu', '0'),
-            'display-logo' => $this->config->getAppValue('side_menu', 'display-logo', '1'),
-            'use-avatar' => $this->config->getAppValue('side_menu', 'use-avatar', '0'),
-            'opener-position' => $this->config->getAppValue('side_menu', 'opener-position', 'before'),
-            'opener-hover' => $this->config->getAppValue('side_menu', 'opener-hover', '0'),
-            'opener-only' => $this->config->getAppValue('side_menu', 'opener-only', '0'),
-            'hide-when-no-apps' => $this->config->getAppValue('side_menu', 'hide-when-no-apps', '0'),
-            'size-icon' => $this->config->getAppValue('side_menu', 'size-icon', 'normal'),
-            'size-text' => $this->config->getAppValue('side_menu', 'size-text', 'normal'),
-            'target-blank-apps' => (array) json_decode($this->config->getAppValue('side_menu', 'target-blank-apps', '[]'), true),
-            'top-menu-apps' => (array) json_decode($this->config->getAppValue('side_menu', 'top-menu-apps', '[]'), true),
+            'current-app-background-color' => $this->config->getAppValue('current-app-background-color', '#444444'),
+            'loader-color' => $this->config->getAppValue('loader-color', '#0e75ac'),
+            'icon-invert-filter' => $this->config->getAppValueInt('icon-invert-filter', '0'),
+            'icon-opacity' => $this->config->getAppValueInt('icon-opacity', '100'),
+            'loader-enabled' => $this->config->getAppValue('loader-enabled', '1'),
+            'text-color' => $this->config->getAppValue('text-color', '#FFFFFF'),
+            'cache' => $this->config->getAppValue('cache', '0'),
+            'opener' => $this->config->getAppValue('opener', 'side-menu-opener'),
+            'always-displayed' => $this->config->getAppValue('always-displayed', '0'),
+            'big-menu' => $this->config->getAppValue('big-menu', '0'),
+            'display-logo' => $this->config->getAppValue('display-logo', '1'),
+            'use-avatar' => $this->config->getAppValue('use-avatar', '0'),
+            'opener-position' => $this->config->getAppValue('opener-position', 'before'),
+            'opener-hover' => $this->config->getAppValue('opener-hover', '0'),
+            'opener-only' => $this->config->getAppValue('opener-only', '0'),
+            'hide-when-no-apps' => $this->config->getAppValue('hide-when-no-apps', '0'),
+            'size-icon' => $this->config->getAppValue('size-icon', 'normal'),
+            'size-text' => $this->config->getAppValue('size-text', 'normal'),
+            'force' => $this->config->getAppValue('force', '0'),
+            'target-blank-apps' => $this->config->getAppValueArray('target-blank-apps', '[]'),
+            'top-menu-apps' => $this->config->getAppValueArray('top-menu-apps', '[]'),
             'apps' => $this->appRepository->getVisibleApps(),
         ];
 
-        return new TemplateResponse('side_menu', 'settings/admin-form', $parameters, '');
+        return new TemplateResponse(Application::APP_ID, 'settings/admin-form', $parameters, '');
     }
 
     /**
@@ -97,7 +99,7 @@ class Admin implements ISettings
      */
     public function getSection()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**

lib/Settings/AdminSection.php

@@ -21,6 +21,7 @@ namespace OCA\SideMenu\Settings;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 use OCP\Settings\IIconSection;
+use OCA\SideMenu\AppInfo\Application;
 
 class AdminSection implements IIconSection
 {
@@ -52,7 +53,7 @@ class AdminSection implements IIconSection
      */
     public function getID()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**
@@ -63,7 +64,7 @@ class AdminSection implements IIconSection
      */
     public function getName()
     {
-        return $this->l->t('Side menu');
+        return $this->l->t(Application::APP_NAME);
     }
 
     /**
@@ -83,6 +84,6 @@ class AdminSection implements IIconSection
      */
     public function getIcon()
     {
-        return $this->url->imagePath('theming', 'app-dark.svg');
+        return $this->url->imagePath(Application::APP_ID, 'icon.svg');
     }
 }

lib/Settings/Personal.php

@@ -18,13 +18,14 @@
 
 namespace OCA\SideMenu\Settings;
 
+use OCA\SideMenu\AppInfo\Application;
+use OCA\SideMenu\Service\AppRepository;
+use OCA\SideMenu\Service\ConfigProxy;
 use OCP\AppFramework\Http\TemplateResponse;
 use OCP\IL10N;
 use OCP\ILogger;
-use OCP\Settings\ISettings;
-use OCP\IConfig;
 use OCP\IUserSession;
-use OCA\SideMenu\Service\AppRepository;
+use OCP\Settings\ISettings;
 
 class Personal implements ISettings
 {
@@ -39,7 +40,7 @@ class Personal implements ISettings
     private $logger;
 
     /**
-     * @var IConfig
+     * @var ConfigProxy
      */
     private $config;
 
@@ -53,7 +54,7 @@ class Personal implements ISettings
      */
     private $appRepository;
 
-    public function __construct(IL10N $l, ILogger $logger, IConfig $config, IUserSession $userSession, AppRepository $appRepository)
+    public function __construct(IL10N $l, ILogger $logger, ConfigProxy $config, IUserSession $userSession, AppRepository $appRepository)
     {
         $this->l = $l;
         $this->logger = $logger;
@@ -70,14 +71,15 @@ class Personal implements ISettings
         $user = $this->userSession->getUser();
 
         $parameters = [
-            'enabled' => $this->config->getUserValue($user->getUid(), 'side_menu', 'enabled', '1'),
-            'top-menu-apps' => (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'top-menu-apps', '[]'), true),
-            'target-blank-mode' => $this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-mode', '1'),
-            'target-blank-apps' => (array) json_decode($this->config->getUserValue($user->getUid(), 'side_menu', 'target-blank-apps', '[]'), true),
+            'force' => $this->config->getAppValueBool('force', '0'),
+            'enabled' => $this->config->getUserValue($user, 'enabled', '1'),
+            'top-menu-apps' => $this->config->getUserValueArray($user, 'top-menu-apps', '[]'),
+            'target-blank-mode' => $this->config->getUserValue($user, 'target-blank-mode', '1'),
+            'target-blank-apps' => $this->config->getUserValueArray($user, 'target-blank-apps', '[]'),
             'apps' => $this->appRepository->getVisibleApps(),
         ];
 
-        return new TemplateResponse('side_menu', 'settings/personal-form', $parameters, '');
+        return new TemplateResponse(Application::APP_ID, 'settings/personal-form', $parameters, '');
     }
 
     /**
@@ -85,13 +87,13 @@ class Personal implements ISettings
      */
     public function getSection()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**
      * @return int whether the form should be rather on the top or bottom of
-     * the admin section. The forms are arranged in ascending order of the
-     * priority values. It is required to return a value between 0 and 100.
+     *             the admin section. The forms are arranged in ascending order of the
+     *             priority values. It is required to return a value between 0 and 100.
      *
      * E.g.: 70
      */

lib/Settings/PersonalSection.php

@@ -21,6 +21,7 @@ namespace OCA\SideMenu\Settings;
 use OCP\IL10N;
 use OCP\IURLGenerator;
 use OCP\Settings\IIconSection;
+use OCA\SideMenu\AppInfo\Application;
 
 class PersonalSection implements IIconSection
 {
@@ -52,7 +53,7 @@ class PersonalSection implements IIconSection
      */
     public function getID()
     {
-        return 'side_menu';
+        return Application::APP_ID;
     }
 
     /**
@@ -63,7 +64,7 @@ class PersonalSection implements IIconSection
      */
     public function getName()
     {
-        return $this->l->t('Side menu');
+        return $this->l->t(Application::APP_NAME);
     }
 
     /**
@@ -83,6 +84,6 @@ class PersonalSection implements IIconSection
      */
     public function getIcon()
     {
-        return $this->url->imagePath('theming', 'app-dark.svg');
+        return $this->url->imagePath(Application::APP_ID, 'icon.svg');
     }
 }

src/SideMenu.vue

@@ -19,9 +19,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
         <div class="side-menu-header">
             <button class="side-menu-opener"></button>
 
-            <div v-if="logo" v-bind:class="{'side-menu-logo': true, 'avatardiv': isAvatar}">
+            <div v-if="!avatar && logo" v-bind:class="{'side-menu-logo': true, 'avatardiv': false}">
                 <img v-bind:src="logo">
             </div>
+            <div v-if="avatar" v-bind:class="{'side-menu-logo': true, 'avatardiv': true}">
+                <img v-bind:src="avatar">
+            </div>
         </div>
 
         <ul class="side-menu-apps-list">
@@ -37,6 +40,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
 
 <script>
 import trim from 'trim'
+import axios from 'axios'
 
 export default {
     name: 'SideMenu',
@@ -44,9 +48,9 @@ export default {
         return {
             apps: [],
             logo: null,
+            avatar: null,
             forceLightIcon: false,
-			targetBlank: false,
-			isAvatar: false,
+            targetBlankApps: [],
         }
     },
     methods: {
@@ -88,7 +92,7 @@ export default {
                     }
 
                     this.apps.push({
-						id: dataId,
+                        id: dataId,
                         href: href,
                         name: trim(element.querySelector('span').innerHTML),
                         icon: svg,
@@ -103,30 +107,25 @@ export default {
                 }, 1000)
             })(this.apps)
         },
-        retrieveLogo() {
-            const ncLogo = document.querySelector('#nextcloud .logo')
-			const avatar = document.querySelector('#side-menu-container').getAttribute('data-avatar');
 
-			if (avatar) {
-				this.logo = avatar
-				this.isAvatar = true
-			} else if (ncLogo) {
-                const url = window.getComputedStyle(ncLogo, null)
-                    .getPropertyValue('background-image')
-                    .replace('url("', '')
-                    .replace('")', '')
+        retrieveConfig() {
+            let that = this
 
-                if (url && url !== 'none') {
-                    this.logo = url
-                }
-            }
+            axios
+                .get(OC.generateUrl('/apps/side_menu/js/config'))
+                .then(function(response) {
+                    const config = response.data
+
+                    that.targetBlankApps = config['target-blank-apps']
+                    that.forceLightIcon = config['force-light-icon']
+                    that.avatar = config['avatar']
+                    that.logo = config['logo']
+                });
         },
     },
     mounted() {
+        this.retrieveConfig()
         this.retrieveApps()
-        this.retrieveLogo()
-        this.forceLightIcon = document.querySelector('#side-menu-container').getAttribute('data-forcelighticon') == 1;
-        this.targetBlankApps = document.querySelector('#side-menu-container').getAttribute('data-targetblankapps').split(',');
 
         const menu = document.querySelector('#appmenu')
 

src/SideMenuBig.vue

@@ -18,11 +18,30 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
     <div id="side-menu" class="side-menu-big">
         <div class="side-menu-header">
             <button class="side-menu-opener side-menu-closer"></button>
-			<button class="side-menu-opener"></button>
+            <button class="side-menu-opener"></button>
         </div>
 
         <div class="side-menu-categories-wrapper">
             <div class="side-menu-categories">
+                <div v-if="!items.length" class="side-menu-loader">
+                    <svg width="38" height="38" viewBox="0 0 38 38" xmlns="http://www.w3.org/2000/svg">
+                        <g fill="none" fill-rule="evenodd">
+                            <g transform="translate(1 1)" stroke-width="2">
+                                <circle stroke-opacity=".5" cx="18" cy="18" r="18"/>
+                                <path d="M36 18c0-9.94-8.06-18-18-18">
+                                    <animateTransform
+                                        attributeName="transform"
+                                        type="rotate"
+                                        from="0 18 18"
+                                        to="360 18 18"
+                                        dur="1s"
+                                        repeatCount="indefinite"/>
+                                </path>
+                            </g>
+                        </g>
+                    </svg>
+                </div>
+
                 <div class="side-menu-category" v-for="category in items">
                     <h2 class="side-menu-category-title" v-if="category.name != ''" v-html="category.name"></h2>
 
@@ -50,7 +69,8 @@ export default {
         return {
             items: [],
             activeApp: null,
-			targetBlank: false,
+            targetBlank: false,
+            targetBlankApps: [],
         }
     },
     methods: {
@@ -74,14 +94,26 @@ export default {
                     jQuery('body').trigger('side-menu.apps', [apps])
                 });
         },
+
         retrieveActiveApp() {
             let activeAppLink = document.querySelector('#appmenu a.active')
             this.activeApp = activeAppLink ? activeAppLink.parentNode.getAttribute('data-id') : null
         },
+
+        retrieveConfig() {
+            let that = this
+
+            axios
+                .get(OC.generateUrl('/apps/side_menu/js/config'))
+                .then(function(response) {
+                    const config = response.data
+
+                    that.targetBlankApps = config['target-blank-apps']
+                });
+        },
     },
     mounted() {
-        this.targetBlankApps = document.querySelector('#side-menu-container').getAttribute('data-targetblankapps').split(',');
-
+        this.retrieveConfig()
         this.retrieveApps()
         this.retrieveActiveApp()
     }

src/l10n/fixtures/de.yaml

@@ -1,5 +1,5 @@
-"Side menu": "Seitenmenü"
-"Enable the side menu": "Aktiviere das Seitenmenü"
+"Custom menu": "Benutzerdefiniertes Menü"
+"Enable the custom menu": "Aktiviere das Benutzerdefiniertes Menü"
 "No": "Nein"
 "Yes": "Ja"
 "Menu": "Menü"
@@ -56,3 +56,8 @@
 "Use the global setting": "Verwende die globale Einstellung"
 "Use my selection": "Verwende meine Auswahl"
 "Show and hide the list of applications": "Ein- und Ausblenden der Anwendungsliste"
+"Use the avatar instead of the logo": "Verwenden Sie den Avatar anstelle des Logos"
+"You do not have permission to change the settings.": "Sie haben keine Berechtigung zum Ändern der Einstellungen."
+"Force this configuration to users": "Erzwingen Sie diese Konfiguration für Benutzer"
+"Export the configuration": "Exportieren Sie die Konfiguration"
+"Purge the cache": "Leeren Sie den Cache"

src/l10n/fixtures/fr.yaml

@@ -1,5 +1,5 @@
-"Side menu": "Menu latéral"
-"Enable the side menu": "Activer le menu latéral"
+"Custom menu": "Menu personnalisé"
+"Enable the custom menu": "Activer le menu personnalisé"
 "No": "Non"
 "Yes": "Oui"
 "Menu": "Menu"
@@ -56,3 +56,8 @@
 "Use the global setting": "Utiliser la configuration globale"
 "Use my selection": "Utiliser ma sélection"
 "Show and hide the list of applications": "Afficher et masquer la liste des applications"
+"Use the avatar instead of the logo": "Utiliser l'avatar à la place du logo"
+"You do not have permission to change the settings.": "Vous n'avez pas la permission de changer les paramètres."
+"Force this configuration to users": "Forcer cette configuration aux utilisateurs"
+"Export the configuration": "Exporter la configuration"
+"Purge the cache": "Purger le cache"

templates/js/_alwaysDisplayed.js

@@ -41,4 +41,28 @@ var alwaysDisplayed = function() {
     }
 }
 
-window.setTimeout(alwaysDisplayed, 200)
+let content = document.getElementById('content')
+
+if (content && content.classList.contains('app-settings')) {
+    let loaded = false
+    const config = {attributes: false, childList: true, subtree: true}
+    const observer = new MutationObserver(() => {
+        if (loaded) {
+            return;
+        }
+
+        const element = content.querySelector('#app-category-your-apps')
+            || content.querySelector('#app-navigation ul')
+
+        if (element) {
+            loaded = true
+
+            alwaysDisplayed()
+        }
+    })
+
+    observer.observe(content, config)
+} else {
+    window.setTimeout(alwaysDisplayed, 200)
+}
+

templates/js/_topMenuApps.js

@@ -108,6 +108,28 @@ var updateTopMenu = function() {
         k++
     })
 
+    // Hack for https://github.com/nextcloud/server/blob/23b0b63c213f5b31eecae817ffd4a9e26f6624d0/core/src/components/MainMenu.js#L74-L96
+    menu.undelegate('li:not(#more-apps) > a', 'click')
+    menu.delegate('li:not(#more-apps) > a', 'click', function(e) {
+        var a = $(e.target)
+
+        if (!a.is('a')) {
+            a = a.closest('a')
+        }
+
+        if (a.attr('target') !== '_blank' && e.which === 1 && !e.ctrlKey && !e.metaKey && a.parent('#more-apps').length === 0) {
+            a.find('svg').remove()
+            a.find('div').remove()
+            a.prepend(jQuery('<div/>').addClass(
+                OCA.Theming && OCA.Theming.inverted
+                ? 'icon-loading-small'
+                : 'icon-loading-small-dark'
+            ))
+
+            window.location.href = a.attr('href')
+        }
+    })
+
     jQuery('#apps li.app-external-site').each(function(i, app) {
         app = jQuery(app)
         var appId = app.attr('data-id')

templates/js/script.php

@@ -10,16 +10,6 @@
         sideMenu.attr('data-bigmenu', '1')
     <?php endif; ?>
 
-    <?php if ($_['force-light-icon']): ?>
-        sideMenuContainer.attr('data-forcelighticon', '1')
-    <?php endif; ?>
-    
-    <?php if ($_['avatar']): ?>
-        sideMenuContainer.attr('data-avatar', '<?php p($avatar) ?>')
-    <?php endif; ?>
-
-    sideMenuContainer.attr('data-targetblankapps', '<?php p(implode(',', $_['target-blank-apps'])) ?>')
-
     var targetBlankApps = <?php echo json_encode($_['target-blank-apps']) ?>;
 
     body.on('side-menu.apps', function(e, apps) {
@@ -95,10 +85,10 @@
                     headerMenuOpener.on('mouseenter', sideMenuOpenerMouseEnter)
 
                     sideMenu.addClass('hide-opener')
-                <?php else: ?>
-                    sideMenu.on('mouseleave', sideMenuMouseLeave)
-                    sideMenu.on('mouseenter', sideMenuOpenerMouseEnter)
                 <?php endif ?>
+
+                sideMenu.on('mouseleave', sideMenuMouseLeave)
+                sideMenu.on('mouseenter', sideMenuOpenerMouseEnter)
             }
         <?php endif; ?>
 

templates/settings/admin-form.php

@@ -16,9 +16,15 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+use OCP\IURLGenerator;
+use OCP\IConfig;
+use OCA\SideMenu\AppInfo\Application;
+
 script('side_menu', 'admin');
 style('side_menu', 'admin');
-style('side_menu', 'support');
+
+$urlGenerator = \OC::$server[IURLGenerator::class];
+$cacheSize = floor(mb_strlen(\OC::$server[IConfig::class]->getAppValue(Application::APP_ID, 'cache-categories', ''), '8bit') / 1024);
 
 $choicesYesNo = [
     'No' => '0',
@@ -31,6 +37,7 @@ $choicesSizes = [
     'Normal' => 'normal',
     'Big' => 'big',
 ];
+
 ?>
 
 <div id="side-menu-section">
@@ -473,11 +480,41 @@ $choicesSizes = [
     </div>
 
     <div class="section">
+        <div>
+            <label for="side-menu-opener-only">
+                <?php p($l->t('Force this configuration to users')); ?>
+            </label>
+
+            <select id="side-menu-force" name="force" class="side-menu-setting">
+                <?php foreach ($choicesYesNo as $label => $value): ?>
+                    <option value="<?php echo $value ?>" <?php if ($value === $_['force']): ?>selected<?php endif; ?>>
+                        <?php echo $l->t($label);  ?>
+                    </option>
+                <?php endforeach; ?>
+            </select>
+        </div>
+
         <input type="hidden" id="side-menu-cache" name="cache" value="<?php print_unescaped($_['cache']); ?>" class="side-menu-setting">
 
-        <button id="side-menu-save" class="btn btn-primary"><?php p($l->t('Save')); ?></button>
+        <button id="side-menu-save" class="btn btn-info">
+            <?php p($l->t('Save')); ?>
+        </button>
 
         <span id="side-menu-message" class="msg"></span>
+    </div>
+
+    <div class="section" id="more">
+        <a href="<?php echo $urlGenerator->linkToRoute('side_menu.AdminSetting.exportConfiguration') ?>" target="_blank">
+            <button class="btn btn-primary" >
+                <?php p($l->t('Export the configuration')); ?>
+            </button>
+        </a>
+
+        <a href="<?php echo $urlGenerator->linkToRoute('side_menu.AdminSetting.removeCache') ?>">
+            <button class="btn btn-primary" >
+                <?php p($l->t('Purge the cache')); ?> (<?php echo $cacheSize ?> Kb)
+            </button>
+        </a>
 
         <div style="height: 30px"></div>
 

templates/settings/personal-form.php

@@ -18,7 +18,6 @@
 
 script('side_menu', 'admin');
 style('side_menu', 'admin');
-style('side_menu', 'support');
 
 $choicesYesNo = [
     'No' => '0',
@@ -27,125 +26,142 @@ $choicesYesNo = [
 
 ?>
 
+
 <div id="side-menu-section">
-    <div class="section">
-        <h2>
-            <?php p($l->t('Menu')); ?>
-        </h2>
+    <?php if ($_['force']): ?>
+        <div class="section">
+            <h2>
+                <?php p($l->t('Menu')); ?>
+            </h2>
 
-        <div>
-            <label for="side-menu-enabled">
-                <?php p($l->t('Enable the side menu')); ?>
-            </label>
+            <p>
+                <em><?php echo $l->t('You do not have permission to change the settings.'); ?></em>
+            </p>
         </div>
+    <?php else: ?>
+        <div class="section">
+            <h2>
+                <?php p($l->t('Menu')); ?>
+            </h2>
 
-        <p>
-            <em><?php echo $l->t('Use the shortcut <span class="keyboard-key">Ctrl</span>+<span class="keyboard-key">o</span> to open and to hide the side menu. Use <span class="keyboard-key">tab</span> to navigate.'); ?></em>
-        </p>
 
-        <div>
-            <select id="side-menu-enabled" name="enabled" class="side-menu-setting" data-personal>
-                <?php foreach ($choicesYesNo as $label => $value): ?>
-                    <option value="<?php echo $value ?>" <?php if ($value === $_['enabled']): ?>selected<?php endif; ?>>
-                        <?php echo $l->t($label); ?>
-                    </option>
+
+            <div>
+                <label for="side-menu-enabled">
+                    <?php p($l->t('Enable the custom menu')); ?>
+                </label>
+            </div>
+
+            <p>
+                <em><?php echo $l->t('Use the shortcut <span class="keyboard-key">Ctrl</span>+<span class="keyboard-key">o</span> to open and to hide the side menu. Use <span class="keyboard-key">tab</span> to navigate.'); ?></em>
+            </p>
+
+            <div>
+                <select id="side-menu-enabled" name="enabled" class="side-menu-setting" data-personal>
+                    <?php foreach ($choicesYesNo as $label => $value): ?>
+                        <option value="<?php echo $value ?>" <?php if ($value === $_['enabled']): ?>selected<?php endif; ?>>
+                            <?php echo $l->t($label); ?>
+                        </option>
+                    <?php endforeach; ?>
+                </select>
+            </div>
+
+            <div>
+                <label for="side-menu-target-blank">
+                    <?php p($l->t('Open apps in new tab')); ?>
+                </label>
+            </div>
+
+            <div>
+                <?php $choices = [
+                    'Use the global setting' => '1',
+                    'Use my selection' => '2',
+                ]; ?>
+
+                <select id="side-menu-loader-enabled" name="target-blank-mode" class="side-menu-setting" data-personal>
+                    <?php foreach ($choices as $label => $value): ?>
+                        <option value="<?php echo $value ?>" <?php if ($value === $_['target-blank-mode']): ?>selected<?php endif; ?>>
+                            <?php echo $l->t($label);  ?>
+                        </option>
+                    <?php endforeach; ?>
+                </select>
+            </div>
+
+            <p>
+                <a class="side-menu-toggler" data-target="#target-blank-apps" href="#_">
+                    🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                </a>
+            </p>
+
+            <div class="side-menu-setting" data-name="target-blank-apps" id="target-blank-apps" data-personal data-checkbox style="display: none">
+                <?php foreach ($_['apps'] as $app): ?>
+                    <div>
+                        <input
+                            type="checkbox"
+                            name="target-blank-apps[]"
+                            value="<?php echo $app['id'] ?>"
+                            id="target-blank-app-<?php echo $app['id'] ?>"
+                            <?php if (in_array($app['id'], $_['target-blank-apps'])): ?>checked<?php endif; ?>
+                        />
+
+                        <label for="target-blank-app-<?php echo $app['id'] ?>">
+                            <?php echo p($l->t($app['name'])); ?>
+                        </label>
+                    </div>
                 <?php endforeach; ?>
-            </select>
+            </div>
         </div>
 
-        <div>
-            <label for="side-menu-target-blank">
-                <?php p($l->t('Open apps in new tab')); ?>
-            </label>
-        </div>
+        <div class="section">
+            <h2>
+                <?php p($l->t('Top menu')); ?>
+            </h2>
+            <div>
+                <label for="side-menu-top-menu-apps">
+                    <?php p($l->t('Apps that not must be moved in the side menu')); ?>
+                </label>
+            </div>
 
-        <div>
-            <?php $choices = [
-                'Use the global setting' => '1',
-                'Use my selection' => '2',
-            ]; ?>
+            <p>
+                <em>
+                    <?php p($l->t('If there is no selection then the global configuration is applied.')); ?>
+                </em>
+            </p>
 
-            <select id="side-menu-loader-enabled" name="target-blank-mode" class="side-menu-setting" data-personal>
-                <?php foreach ($choices as $label => $value): ?>
-                    <option value="<?php echo $value ?>" <?php if ($value === $_['target-blank-mode']): ?>selected<?php endif; ?>>
-                        <?php echo $l->t($label);  ?>
-                    </option>
+            <p>
+                <a class="side-menu-toggler" data-target="#top-menu-apps" href="#_">
+                    🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
+                </a>
+            </p>
+
+            <div class="side-menu-setting" data-name="top-menu-apps" data-checkbox data-personal id="top-menu-apps" style="display: none">
+                <?php foreach ($_['apps'] as $app): ?>
+                    <div>
+                        <input
+                            type="checkbox"
+                            name="top-menu-apps[]"
+                            value="<?php echo $app['id'] ?>"
+                            id="top-menu-app-<?php echo $app['id'] ?>"
+                            <?php if (in_array($app['id'], $_['top-menu-apps'])): ?>checked<?php endif; ?>
+                        />
+
+                        <label for="top-menu-app-<?php echo $app['id'] ?>">
+                            <?php echo $app['name'] ?>
+                        </label>
+                    </div>
                 <?php endforeach; ?>
-            </select>
+            </div>
         </div>
-
-        <p>
-            <a class="side-menu-toggler" data-target="#target-blank-apps" href="#_">
-                🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
-            </a>
-        </p>
-
-        <div class="side-menu-setting" data-name="target-blank-apps" id="target-blank-apps" data-personal data-checkbox style="display: none">
-            <?php foreach ($_['apps'] as $app): ?>
-                <div>
-                    <input
-                        type="checkbox"
-                        name="target-blank-apps[]"
-                        value="<?php echo $app['id'] ?>"
-                        id="target-blank-app-<?php echo $app['id'] ?>"
-                        <?php if (in_array($app['id'], $_['target-blank-apps'])): ?>checked<?php endif; ?>
-                    />
-
-                    <label for="target-blank-app-<?php echo $app['id'] ?>">
-                        <?php echo p($l->t($app['name'])); ?>
-                    </label>
-                </div>
-            <?php endforeach; ?>
-        </div>
-    </div>
+    <?php endif ?>
 
     <div class="section">
-        <h2>
-            <?php p($l->t('Top menu')); ?>
-        </h2>
-        <div>
-            <label for="side-menu-top-menu-apps">
-                <?php p($l->t('Apps that not must be moved in the side menu')); ?>
-            </label>
-        </div>
+        <?php if (!$_['force']): ?>
+            <button id="side-menu-save" class="btn btn-primary"><?php p($l->t('Save')); ?></button>
 
-        <p>
-            <em>
-                <?php p($l->t('If there is no selection then the global configuration is applied.')); ?>
-            </em>
-        </p>
+            <span id="side-menu-message" class="msg"></span>
 
-        <p>
-            <a class="side-menu-toggler" data-target="#top-menu-apps" href="#_">
-                🖱️ <?php p($l->t('Show and hide the list of applications')); ?>
-            </a>
-        </p>
-
-        <div class="side-menu-setting" data-name="top-menu-apps" data-checkbox data-personal id="top-menu-apps" style="display: none">
-            <?php foreach ($_['apps'] as $app): ?>
-                <div>
-                    <input
-                        type="checkbox"
-                        name="top-menu-apps[]"
-                        value="<?php echo $app['id'] ?>"
-                        id="top-menu-app-<?php echo $app['id'] ?>"
-                        <?php if (in_array($app['id'], $_['top-menu-apps'])): ?>checked<?php endif; ?>
-                    />
-
-                    <label for="top-menu-app-<?php echo $app['id'] ?>">
-                        <?php echo $app['name'] ?>
-                    </label>
-                </div>
-            <?php endforeach; ?>
-        </div>
-    </div>
-
-    <div class="section">
-        <button id="side-menu-save" class="btn btn-primary"><?php p($l->t('Save')); ?></button>
-
-        <span id="side-menu-message" class="msg"></span>
-
-        <div style="height: 30px"></div>
+            <div style="height: 30px"></div>
+        <?php endif ?>
 
         <div>
             <span for="side-menu-opener">